Skip to content

feat: add segmented control component#14066

Merged
amitabh94 merged 1 commit into
mainfrom
feature/segmented-control-component
Mar 18, 2025
Merged

feat: add segmented control component#14066
amitabh94 merged 1 commit into
mainfrom
feature/segmented-control-component

Conversation

@amitabh94

@amitabh94 amitabh94 commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

Description

This PR adds a new component

  • SegmentedControl: A versatile control component supporting both single and multi-select modes, with options for scrollable content and icon integration

Figma Designs:

Segmented Control : https://www.figma.com/design/HKpPKij9V3TpsyMV1TpV7C/DS-Components?node-id=21177-52932&t=h4Y3QeK29FY8VgjR-4

Related issues

Fixes: MMS-1988

Manual testing steps

SegmentedControl Component

  • Navigate to Storybook and locate the SegmentedControl stories

  • Test single-select mode:
    - Verify only one option can be selected at a time
    - Confirm the selected option is visually distinguished

  • Test multi-select mode:
    - Verify multiple options can be selected simultaneously
    - Confirm selected options are visually distinguished
    - Test adding and removing selections
    - Test scrollable configuration with many options
    - Verify options with icons render correctly

Screenshots/Recordings

Before

After

Segmented Control Storybook

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-03-14.at.01.13.50.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-stake-deprecated DEPRECATED: please use "team-earn" instead label Mar 17, 2025
@amitabh94 amitabh94 force-pushed the feature/segmented-control-component branch from d360e7a to d79fccc Compare March 17, 2025 21:45
@amitabh94 amitabh94 added team-swaps-deprecated DEPRECATED: please use "team-swaps-and-bridge" instead team-swaps-and-bridge Swaps and Bridge team Run Smoke E2E and removed team-stake-deprecated DEPRECATED: please use "team-earn" instead labels Mar 17, 2025
@github-actions

github-actions Bot commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d79fccc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3eb1c1d0-c73b-49bc-86c5-b1b941565010

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@amitabh94 amitabh94 marked this pull request as ready for review March 17, 2025 22:14
@amitabh94 amitabh94 requested review from a team as code owners March 17, 2025 22:14
@amitabh94 amitabh94 enabled auto-merge March 17, 2025 22:14
@amitabh94 amitabh94 force-pushed the feature/segmented-control-component branch from a9dd07a to b1a2604 Compare March 17, 2025 22:38
@sonarqubecloud

Copy link
Copy Markdown

@amitabh94 amitabh94 added this pull request to the merge queue Mar 18, 2025
Merged via the queue into main with commit 35e4a7c Mar 18, 2025
@amitabh94 amitabh94 deleted the feature/segmented-control-component branch March 18, 2025 01:04
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 18, 2025
@metamaskbot metamaskbot added the release-7.44.0 Issue or pull request that will be included in release 7.44.0 label Mar 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.44.0 Issue or pull request that will be included in release 7.44.0 team-swaps-and-bridge Swaps and Bridge team team-swaps-deprecated DEPRECATED: please use "team-swaps-and-bridge" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants