Skip to content

feat: add button toggle component#14064

Merged
amitabh94 merged 2 commits into
mainfrom
feat/add-button-toggle-component
Mar 17, 2025
Merged

feat: add button toggle component#14064
amitabh94 merged 2 commits into
mainfrom
feat/add-button-toggle-component

Conversation

@amitabh94

@amitabh94 amitabh94 commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR adds a new component :

ButtonToggle: A new toggle button component that visually indicates active/inactive states with appropriate styling changes.

Related issues

Fixes: MMS-1988

Manual testing steps

ButtonToggle Component

  • Navigate to Storybook and locate the ButtonToggle stories
  • Verify the button appears correctly in both active and inactive states

Screenshots/Recordings

Before

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@amitabh94 amitabh94 added team-swaps-deprecated DEPRECATED: please use "team-swaps-and-bridge" instead team-swaps-and-bridge Swaps and Bridge team Run Smoke E2E labels Mar 17, 2025
@amitabh94 amitabh94 changed the base branch from MMS-1988--fe-bridge-slippage-modal-component to main March 17, 2025 21:26
@amitabh94 amitabh94 marked this pull request as ready for review March 17, 2025 21:32
@amitabh94 amitabh94 requested review from a team as code owners March 17, 2025 21:32
@amitabh94 amitabh94 enabled auto-merge March 17, 2025 21:58
@github-actions

github-actions Bot commented Mar 17, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 51a0694
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ba6165b3-758a-46e5-af90-017e13129b25

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud

sonarqubecloud Bot commented Mar 17, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@amitabh94 amitabh94 added this pull request to the merge queue Mar 17, 2025
Merged via the queue into main with commit 794884a Mar 17, 2025
@amitabh94 amitabh94 deleted the feat/add-button-toggle-component branch March 17, 2025 22:28
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 17, 2025
@metamaskbot metamaskbot added the release-7.44.0 Issue or pull request that will be included in release 7.44.0 label Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@brianacnguyen brianacnguyen brianacnguyen approved these changes

Assignees

No one assigned

Labels

release-7.44.0 Issue or pull request that will be included in release 7.44.0 team-swaps-and-bridge Swaps and Bridge team team-swaps-deprecated DEPRECATED: please use "team-swaps-and-bridge" instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amitabh94 @brianacnguyen @metamaskbot