Skip to content

fix: cp-7.43.0 Updated ThemeProvider to no longer have wrapping View#14056

Merged
gambinish merged 5 commits into
mainfrom
fix/theme-provider-2
Mar 17, 2025
Merged

fix: cp-7.43.0 Updated ThemeProvider to no longer have wrapping View#14056
gambinish merged 5 commits into
mainfrom
fix/theme-provider-2

Conversation

@brianacnguyen

@brianacnguyen brianacnguyen commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR updated the ThemeProvider to no longer have wrapping View

Related issues

Fixes: Bitrise errors https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5260ec4d-6e9a-4a39-9710-7fc2f1af3db6

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

https://github.com/user-attachments/assets/fc79a1ee-3f0d-44b6-93a0-ea6566c751fe
https://github.com/user-attachments/assets/bfd1dae2-ff1d-400e-b6e5-a588f89b9d7b

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile Run Smoke E2E labels Mar 17, 2025
@brianacnguyen brianacnguyen self-assigned this Mar 17, 2025
@brianacnguyen brianacnguyen requested review from a team as code owners March 17, 2025 17:09
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Mar 17, 2025
@github-actions

github-actions Bot commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

github-actions Bot commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: f5096e7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9369af9e-a99c-4863-ba4f-1a03014d24b2

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions

github-actions Bot commented Mar 17, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f0d0983
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/076df77d-6769-4a35-8da2-810596cc475d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 7a9e7da
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e560a053-118e-4e37-9559-e3e436455b78

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko changed the title fix: Updated ThemeProvider to no longer have wrapping View fix: cp-7.43.0 Updated ThemeProvider to no longer have wrapping View Mar 17, 2025
@github-actions

github-actions Bot commented Mar 17, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5a054fe
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fd7841be-84f3-419b-a1ca-b7c94b6f328f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Mar 17, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

chrisleewilcox
chrisleewilcox approved these changes Mar 17, 2025
View reviewed changes

@chrisleewilcox chrisleewilcox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Mar 17, 2025
@gambinish gambinish added this pull request to the merge queue Mar 17, 2025
Merged via the queue into main with commit abea17a Mar 17, 2025
@gambinish gambinish deleted the fix/theme-provider-2 branch March 17, 2025 21:03
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 17, 2025
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 17, 2025
@metamaskbot metamaskbot added the release-7.44.0 Issue or pull request that will be included in release 7.44.0 label Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

@gambinish gambinish gambinish approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels

release-7.44.0 Issue or pull request that will be included in release 7.44.0 team-design-system All issues relating to design system in Mobile

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@brianacnguyen @chrisleewilcox @georgewrmarshall @gambinish @metamaskbot