fix: cp-7.43.0 remove network fee section in notification details#14050
Merged
Prithpal-Sooriya merged 1 commit intoMar 17, 2025
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
|
this is an expensive set of RPC calls which we plan to optimise in the backend
c482a55 to
4c74a4a
Compare
Contributor
|
|
salimtb
approved these changes
Mar 17, 2025
gambinish
reviewed
Mar 17, 2025
gambinish
approved these changes
Mar 17, 2025
gambinish
left a comment
Member
There was a problem hiding this comment.
Approving with a non-blocking nit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This is an expensive set of RPC calls which we plan to optimise in the backend. This is causing some slowness in the UI, and is not critical for this MVP.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
https://www.loom.com/share/2bb90faf9c984ea4a7411ceb1a9695e2?sid=4aea94af-0f5c-4507-89c0-86ff15b05bc2
After
There is no "network fee" section, and notifications load faster and are much more responsive.
Pre-merge author checklist
Pre-merge reviewer checklist