Skip to content

fix: cp-7.43.0 remove network fee section in notification details#14050

Merged
Prithpal-Sooriya merged 1 commit into
mainfrom
fix/remove-notification-details-network-fee-component
Mar 17, 2025
Merged

fix: cp-7.43.0 remove network fee section in notification details#14050
Prithpal-Sooriya merged 1 commit into
mainfrom
fix/remove-notification-details-network-fee-component

Conversation

@Prithpal-Sooriya

@Prithpal-Sooriya Prithpal-Sooriya commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

This is an expensive set of RPC calls which we plan to optimise in the backend. This is causing some slowness in the UI, and is not critical for this MVP.

Description

Related issues

Fixes:

Manual testing steps

  1. Create a funds sent notification.
  2. Navigate to notification details.
  3. See if the network fee dropdown is removed.

Screenshots/Recordings

Before

https://www.loom.com/share/2bb90faf9c984ea4a7411ceb1a9695e2?sid=4aea94af-0f5c-4507-89c0-86ff15b05bc2

After

There is no "network fee" section, and notifications load faster and are much more responsive.

Screenshot 2025-03-17 at 14 23 18

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Prithpal-Sooriya Prithpal-Sooriya requested a review from a team as a code owner March 17, 2025 14:22
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

github-actions Bot commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c482a55f871466ad23c9746f6a8a637a274b15c2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fde6a554-daa6-4a63-9a94-99906712354f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

this is an expensive set of RPC calls which we plan to optimise in the backend
@Prithpal-Sooriya Prithpal-Sooriya force-pushed the fix/remove-notification-details-network-fee-component branch from c482a55 to 4c74a4a Compare March 17, 2025 16:34
@github-actions

github-actions Bot commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4c74a4a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cb4e1951-ae9b-44fc-b599-043584f6f0ce

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

Copy link
Copy Markdown

@gambinish gambinish left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a non-blocking nit

@Prithpal-Sooriya Prithpal-Sooriya added this pull request to the merge queue Mar 17, 2025
Merged via the queue into main with commit f975775 Mar 17, 2025
@Prithpal-Sooriya Prithpal-Sooriya deleted the fix/remove-notification-details-network-fee-component branch March 17, 2025 17:39
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 17, 2025
@metamaskbot metamaskbot added the release-7.44.0 Issue or pull request that will be included in release 7.44.0 label Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.44.0 Issue or pull request that will be included in release 7.44.0 team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants