Skip to content

fix: cp-7.43.0 updated root to use themeprovider#14040

Merged
cortisiko merged 1 commit into
mainfrom
fix/themeprovider
Mar 17, 2025
Merged

fix: cp-7.43.0 updated root to use themeprovider#14040
cortisiko merged 1 commit into
mainfrom
fix/themeprovider

Conversation

@brianacnguyen

@brianacnguyen brianacnguyen commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

Description

This PR updates the Root file to use ThemeProvider

Related issues

Fixes: #14039

Manual testing steps

  1. Go to home
  2. Toggle theme

Screenshots/Recordings

Before

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-03-14.at.16.38.01.mp4

After

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-03-14.at.16.34.12.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added the team-design-system All issues relating to design system in Mobile label Mar 14, 2025
@brianacnguyen brianacnguyen self-assigned this Mar 14, 2025
@brianacnguyen brianacnguyen requested review from a team and cortisiko March 14, 2025 23:38
@github-actions

github-actions Bot commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

github-actions Bot commented Mar 14, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b254c65
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c9b20cbc-b788-4938-b238-e13c7aca358d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@brianacnguyen brianacnguyen added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 14, 2025
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Mar 14, 2025
@sonarqubecloud

sonarqubecloud Bot commented Mar 14, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cortisiko cortisiko changed the title fix: updated root to use themeprovider fix: cp-7.43.0 updated root to use themeprovider Mar 17, 2025
cortisiko
cortisiko approved these changes Mar 17, 2025
View reviewed changes

@cortisiko cortisiko left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ ✅

@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Mar 17, 2025
@cortisiko cortisiko added this pull request to the merge queue Mar 17, 2025
Merged via the queue into main with commit 047afd7 Mar 17, 2025
@cortisiko cortisiko deleted the fix/themeprovider branch March 17, 2025 15:32
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Mar 17, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 17, 2025
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 17, 2025
@metamaskbot metamaskbot added the release-7.44.0 Issue or pull request that will be included in release 7.44.0 label Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cortisiko cortisiko cortisiko approved these changes

@vinnyhoward vinnyhoward vinnyhoward approved these changes

@Cal-L Cal-L Awaiting requested review from Cal-L

Assignees

@brianacnguyen brianacnguyen

Labels

release-7.44.0 Issue or pull request that will be included in release 7.44.0 team-design-system All issues relating to design system in Mobile

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Broken dark mode experience

4 participants

@brianacnguyen @cortisiko @vinnyhoward @metamaskbot