Skip to content

fix: #9487 Remove false vault back up failure log#14038

Merged
Cal-L merged 8 commits into
mainfrom
chore/remove-false-vault-backup-failure-log
Mar 17, 2025
Merged

fix: #9487 Remove false vault back up failure log#14038
Cal-L merged 8 commits into
mainfrom
chore/remove-false-vault-backup-failure-log

Conversation

@Cal-L

@Cal-L Cal-L commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

Description

This change removes the log where it's falsely reporting failed vault back up when the keyring controller state changes for two reasons:

  • A state change of the keyring controller by itself is not sufficient to indicate a vault corruption
  • The keyring controller experiences state changes where the vault property is removed in the middle of a new wallet creation

The failure reports happen twice when a new wallet is created

We can remove the log here since there is already a failure condition during log in where it reports a missing vault

await this.handleVaultCorruption();

Related issues

Fixes: Bugs (deprecated)

Manual testing steps

  1. Install this branch
  2. Create new wallet
  3. No false reporting of a failed vault back up should occur
  4. Unit test for backupVault simulates what the failed case will report

Screenshots/Recordings

Before

false-vault-failure.mov

After

correct-vault-reporting.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested a review from a team March 14, 2025 23:20
@Cal-L Cal-L requested a review from a team as a code owner March 14, 2025 23:20
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added team-mobile-platform Mobile Platform team Run Smoke E2E No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 14, 2025
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Mar 14, 2025
@github-actions

github-actions Bot commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ad38528
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/02d55604-3f71-465e-be5e-073a2070644a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Comment thread app/core/BackupVault/backupVault.test.ts Outdated
Comment thread app/constants/error.ts
Comment thread app/core/BackupVault/backupVault.test.ts
Comment thread app/core/BackupVault/backupVault.ts
Comment thread app/core/Engine/Engine.ts
MarioAslau
MarioAslau previously approved these changes Mar 14, 2025

@MarioAslau MarioAslau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Mar 14, 2025
owencraston
owencraston previously approved these changes Mar 14, 2025
@Cal-L Cal-L dismissed stale reviews from owencraston and MarioAslau via 87971ca March 15, 2025 00:00
@github-actions

github-actions Bot commented Mar 15, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 87971ca
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6ee4cd39-3667-4619-9f67-314e288af7dc

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

owencraston
owencraston previously approved these changes Mar 15, 2025
@Cal-L Cal-L enabled auto-merge March 17, 2025 20:27
@sonarqubecloud

Copy link
Copy Markdown

@Cal-L Cal-L added this pull request to the merge queue Mar 17, 2025
Merged via the queue into main with commit 2ea03b6 Mar 17, 2025
@Cal-L Cal-L deleted the chore/remove-false-vault-backup-failure-log branch March 17, 2025 21:46
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 17, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 17, 2025
@metamaskbot metamaskbot added the release-7.44.0 Issue or pull request that will be included in release 7.44.0 label Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.44.0 Issue or pull request that will be included in release 7.44.0 team-mobile-platform Mobile Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants