fix: #9487 Remove false vault back up failure log#14038
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
|
Cal-L
commented
Mar 14, 2025
Cal-L
commented
Mar 14, 2025
Cal-L
commented
Mar 14, 2025
Cal-L
commented
Mar 14, 2025
Cal-L
commented
Mar 14, 2025
owencraston
previously approved these changes
Mar 14, 2025
Contributor
|
owencraston
previously approved these changes
Mar 15, 2025
|
MarioAslau
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This change removes the log where it's falsely reporting failed vault back up when the keyring controller state changes for two reasons:
The failure reports happen twice when a new wallet is created
We can remove the log here since there is already a failure condition during log in where it reports a missing vault
metamask-mobile/app/components/Views/Login/index.js
Line 448 in 23c00a4
Related issues
Fixes: Bugs (deprecated)
Manual testing steps
backupVaultsimulates what the failed case will reportScreenshots/Recordings
Before
false-vault-failure.mov
After
correct-vault-reporting.mov
Pre-merge author checklist
Pre-merge reviewer checklist