Skip to content

fix: cp-7.43.0 moved xcode 16 as default and applied xcode 15 only to testflight builds#14032

Merged
sethkfman merged 1 commit into
mainfrom
fix/e2e-failures-testflight-deploy
Mar 14, 2025
Merged

fix: cp-7.43.0 moved xcode 16 as default and applied xcode 15 only to testflight builds#14032
sethkfman merged 1 commit into
mainfrom
fix/e2e-failures-testflight-deploy

Conversation

@sethkfman

@sethkfman sethkfman commented Mar 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR fixes and Xcode 16 vs. 15 compatibility issue with E2E and TestFlight releases. Prior to this PR E2E was failing but allowed TestFlight releases.

Related issues

Fixes:

Manual testing steps

1. Run TestFlight build should succeed
2. Run E2E build should succeed

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sethkfman sethkfman requested a review from a team March 14, 2025 19:06
@github-actions

github-actions Bot commented Mar 14, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b5422e4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/82a9490d-8e0c-40c9-bb55-1c4a4b06609a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud

sonarqubecloud Bot commented Mar 14, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

chrisleewilcox
chrisleewilcox approved these changes Mar 14, 2025
View reviewed changes

@chrisleewilcox chrisleewilcox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added this pull request to the merge queue Mar 14, 2025
Merged via the queue into main with commit 7ad57a0 Mar 14, 2025
@sethkfman sethkfman deleted the fix/e2e-failures-testflight-deploy branch March 14, 2025 22:10
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 14, 2025
@metamaskbot metamaskbot added the release-7.44.0 Issue or pull request that will be included in release 7.44.0 label Mar 14, 2025
@cortisiko cortisiko changed the title fix: moved xcode 16 as default and applied xcode 15 only to testflight builds fix: cp-7.43.0 moved xcode 16 as default and applied xcode 15 only to testflight builds Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

Assignees

No one assigned

Labels

release-7.44.0 Issue or pull request that will be included in release 7.44.0 team-mobile-platform Mobile Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sethkfman @chrisleewilcox @gauthierpetetin @metamaskbot