Skip to content

fix: cp-7.43.0 add remote feature flag for notifications#14028

Merged
Prithpal-Sooriya merged 1 commit into
mainfrom
feat/integrate-notification-remote-feature-flag
Mar 17, 2025
Merged

fix: cp-7.43.0 add remote feature flag for notifications#14028
Prithpal-Sooriya merged 1 commit into
mainfrom
feat/integrate-notification-remote-feature-flag

Conversation

@Prithpal-Sooriya

@Prithpal-Sooriya Prithpal-Sooriya commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

Description

Adds remote feature flag for notifications (so we can turn on/off dynamically without the build flag)

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

github-actions Bot commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 71f1f751f92e16ad4b187cee677caefd80dce077
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0c68e1bd-aca3-45dd-bb08-b0fbacb07167

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Prithpal-Sooriya Prithpal-Sooriya force-pushed the feat/integrate-notification-remote-feature-flag branch from 71f1f75 to b03435b Compare March 14, 2025 17:13
Comment thread app/util/notifications/constants/config.ts
Comment thread app/util/notifications/constants/config.ts
@github-actions

github-actions Bot commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b03435b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a163acf8-2c95-4877-b3a6-da562fea4043

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

Copy link
Copy Markdown

@Prithpal-Sooriya Prithpal-Sooriya changed the title feat: add remote feature flag for notifications fix: cp-7.43.0 add remote feature flag for notifications Mar 17, 2025
@Prithpal-Sooriya Prithpal-Sooriya added this pull request to the merge queue Mar 17, 2025
Merged via the queue into main with commit 9d582bd Mar 17, 2025
@Prithpal-Sooriya Prithpal-Sooriya deleted the feat/integrate-notification-remote-feature-flag branch March 17, 2025 13:20
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 17, 2025
@metamaskbot metamaskbot added the release-7.44.0 Issue or pull request that will be included in release 7.44.0 label Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.44.0 Issue or pull request that will be included in release 7.44.0 team-assets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants