Skip to content

feat: Add TransactionController metric handlers#14020

Merged
OGPoyraz merged 9 commits into
mainfrom
ogp/4378
Mar 18, 2025
Merged

feat: Add TransactionController metric handlers#14020
OGPoyraz merged 9 commits into
mainfrom
ogp/4378

Conversation

@OGPoyraz

Copy link
Copy Markdown
Member

Description

This PR aims to add TransactionController event handler which mainly added for purpose of collecting transaction metrics.
Also setting StakingDeposit and StakingWithdrawal specific metrics when page is viewed.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4378

Manual testing steps

N/A - No user flow changes

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested review from a team as code owners March 14, 2025 09:58
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Mar 14, 2025
@MetaMask MetaMask deleted a comment from github-actions Bot Mar 14, 2025
@MetaMask MetaMask deleted a comment from github-actions Bot Mar 14, 2025
@github-actions

github-actions Bot commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 1f38227
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0917ba93-0b80-4adb-90eb-470464796e2e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Comment thread app/core/Analytics/events/confirmations/events.ts Outdated
@github-actions

github-actions Bot commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6f3216b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/78e4e25d-65c4-42a8-a07f-597fdf39903b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b144cd0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/77708826-ba28-468f-b28f-7d3268bf2c41

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Mar 18, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 52678d9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9ef76711-6522-4eac-8650-bf3d2e1a1de8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

Copy link
Copy Markdown

@OGPoyraz OGPoyraz added this pull request to the merge queue Mar 18, 2025
@OGPoyraz OGPoyraz removed this pull request from the merge queue due to a manual request Mar 18, 2025
@OGPoyraz OGPoyraz added this pull request to the merge queue Mar 18, 2025
Merged via the queue into main with commit 37cb389 Mar 18, 2025
@OGPoyraz OGPoyraz deleted the ogp/4378 branch March 18, 2025 06:58
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 18, 2025
@metamaskbot metamaskbot added the release-7.44.0 Issue or pull request that will be included in release 7.44.0 label Mar 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.44.0 Issue or pull request that will be included in release 7.44.0 team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants