Skip to content

fix: cp-7.42.0 Refactor AddNickname with missing data#14008

Merged
tommasini merged 6 commits into
mainfrom
fix/cant-find-select-provider-type
Mar 14, 2025
Merged

fix: cp-7.42.0 Refactor AddNickname with missing data#14008
tommasini merged 6 commits into
mainfrom
fix/cant-find-select-provider-type

Conversation

@tommasini

@tommasini tommasini commented Mar 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Add nickname component was missing importing variables!
This passed CI because the comment was forgotten to be addressed:
// @ts-nocheck - Confirmations team or Transactions team

Sentry issue:
https://metamask.sentry.io/issues/6313090523/?project=2299799

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Screen.Recording.2025-03-13.at.20.14.12.mov

After

Screen.Recording.2025-03-14.at.00.10.08.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added QA'd but questions A QA run through has been done but you need clarification on minor issues you found needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Mobile Platform team Run Smoke E2E team-confirmations Push issues to confirmations team labels Mar 13, 2025
@tommasini tommasini requested a review from a team as a code owner March 13, 2025 15:16
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Mar 13, 2025
@github-actions

github-actions Bot commented Mar 13, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

github-actions Bot commented Mar 13, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4091e13
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dfd18dc2-7ee7-4638-a4e1-388658831bb7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

OGPoyraz
OGPoyraz previously approved these changes Mar 13, 2025
View reviewed changes
@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Mar 13, 2025
@tommasini tommasini changed the title chore: Import missing variables chore: Refactor AddNickname with missing data Mar 14, 2025
tommasini
tommasini commented Mar 14, 2025
View reviewed changes
Comment thread app/components/Views/confirmations/ApproveView/Approve/index.js Outdated
@github-actions

github-actions Bot commented Mar 14, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 100ca34
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/59f99b24-1694-47a0-8f0e-fe1187dc591c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

OGPoyraz and others added 2 commits March 14, 2025 08:18
@OGPoyraz OGPoyraz changed the title chore: Refactor AddNickname with missing data fix: cp-7.42.0 Refactor AddNickname with missing data Mar 14, 2025
@codecov-commenter

codecov-commenter commented Mar 14, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.34%. Comparing base (d1d22d7) to head (a1a3fb2).
Report is 91 commits behind head on main.

Files with missing lines Patch % Lines
...nts/ApproveTransactionReview/AddNickname/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14008      +/-   ##
==========================================
+ Coverage   63.42%   64.34%   +0.91%     
==========================================
  Files        2093     2171      +78     
  Lines       45277    46123     +846     
  Branches     6234     6428     +194     
==========================================
+ Hits        28717    29677     +960     
+ Misses      14676    14520     -156     
- Partials     1884     1926      +42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OGPoyraz

OGPoyraz commented Mar 14, 2025

Copy link
Copy Markdown
Member

Thanks for the PR @tommasini , I've also manually tested this, fix work as expected

@tommasini tommasini added skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. and removed QA'd but questions A QA run through has been done but you need clarification on minor issues you found labels Mar 14, 2025
@github-actions

github-actions Bot commented Mar 14, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9c31437
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/65069f0d-d85f-4379-95e9-6d9b4ed59b1a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud

sonarqubecloud Bot commented Mar 14, 2025

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@tommasini

tommasini commented Mar 14, 2025

Copy link
Copy Markdown
Contributor Author

Since the e2e is also failing on main will go ahead and merge the PR https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/871a9564-b752-424f-b3c0-41ec38436564

@tommasini tommasini added this pull request to the merge queue Mar 14, 2025
Merged via the queue into main with commit 64d3ac2 Mar 14, 2025
@tommasini tommasini deleted the fix/cant-find-select-provider-type branch March 14, 2025 11:11
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 14, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 14, 2025
@metamaskbot metamaskbot added the release-7.44.0 Issue or pull request that will be included in release 7.44.0 label Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@OGPoyraz OGPoyraz OGPoyraz approved these changes

@vinistevam vinistevam vinistevam approved these changes

Assignees

No one assigned

Labels

release-7.44.0 Issue or pull request that will be included in release 7.44.0 skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-confirmations Push issues to confirmations team team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tommasini @codecov-commenter @OGPoyraz @vinistevam @gauthierpetetin @metamaskbot