Skip to content

chore: Add performance instrumentation for create Snap account#14002

Merged
tommasini merged 10 commits into
mainfrom
chore/performance-instrumentation-create-snap-account
Mar 17, 2025
Merged

chore: Add performance instrumentation for create Snap account#14002
tommasini merged 10 commits into
mainfrom
chore/performance-instrumentation-create-snap-account

Conversation

@tommasini

@tommasini tommasini commented Mar 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Add performance instrumentation from the init of the snap keyring unil the dialog asking for the account name is created

image

Added to the Sentry performance mobile platform dashboard the respective widgets.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini
Add performance instrumentation from the init of the snap keyring unt…
5d6dad2 
…il the dialog asking for the account name is created
@tommasini tommasini added the team-mobile-platform Mobile Platform team label Mar 13, 2025
@tommasini tommasini requested a review from a team as a code owner March 13, 2025 12:21
@github-actions

github-actions Bot commented Mar 13, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 13, 2025
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Mar 13, 2025
MarioAslau
MarioAslau previously approved these changes Mar 13, 2025
View reviewed changes
@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Mar 13, 2025
@tommasini tommasini added the No QA Needed Apply this label when your PR does not need any QA effort. label Mar 13, 2025
MarioAslau
MarioAslau previously approved these changes Mar 13, 2025
View reviewed changes
@codecov-commenter

codecov-commenter commented Mar 13, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.29%. Comparing base (d1d22d7) to head (1badc08).
Report is 88 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14002      +/-   ##
==========================================
+ Coverage   63.42%   64.29%   +0.86%     
==========================================
  Files        2093     2168      +75     
  Lines       45277    46055     +778     
  Branches     6234     6418     +184     
==========================================
+ Hits        28717    29611     +894     
+ Misses      14676    14520     -156     
- Partials     1884     1924      +40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tommasini tommasini enabled auto-merge March 14, 2025 21:31
@sonarqubecloud

sonarqubecloud Bot commented Mar 17, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Cal-L
Cal-L approved these changes Mar 17, 2025
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini added this pull request to the merge queue Mar 17, 2025
Merged via the queue into main with commit 298b4a5 Mar 17, 2025
@tommasini tommasini deleted the chore/performance-instrumentation-create-snap-account branch March 17, 2025 20:15
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Mar 17, 2025
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 17, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 17, 2025
@metamaskbot metamaskbot added the release-7.44.0 Issue or pull request that will be included in release 7.44.0 label Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

@MarioAslau MarioAslau MarioAslau left review comments

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.44.0 Issue or pull request that will be included in release 7.44.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tommasini @codecov-commenter @Cal-L @MarioAslau @gauthierpetetin @metamaskbot