fix: animation added for loading state on SnapUILink button#13973
Merged
Daniel-Cross merged 11 commits intoMar 14, 2025
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13973 +/- ##
==========================================
+ Coverage 63.42% 64.11% +0.69%
==========================================
Files 2093 2155 +62
Lines 45277 45934 +657
Branches 6234 6399 +165
==========================================
+ Hits 28717 29451 +734
+ Misses 14676 14563 -113
- Partials 1884 1920 +36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FrederikBolding
approved these changes
Mar 13, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added Lottie animation for
SnapUILinkbutton loading state as it's currently unhandled.Related issues
Fixes: MetaMask/snaps#3179
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2025-03-12.at.18.14.07.mov
Pre-merge author checklist
Pre-merge reviewer checklist