Skip to content

feat(ramp): add non evm balance#13948

Merged
wachunei merged 13 commits into
mainfrom
feat/ramp-non-evm-balance
Mar 17, 2025
Merged

feat(ramp): add non evm balance#13948
wachunei merged 13 commits into
mainfrom
feat/ramp-non-evm-balance

Conversation

@wachunei

@wachunei wachunei commented Mar 11, 2025

Copy link
Copy Markdown
Member

Description

This PR extends the useBalance hook of the Ramps folder to support CAIP-19 identifiers of the Ramp assets, currently Solana.

Related issues

Fixes:

Manual testing steps

  1. Go to Buy feature
  2. Reach the Build Quote View
  3. Solana balance must show up below the amount input

Screenshots/Recordings

Before After
image image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-money-movement issues related to Money Movement features label Mar 11, 2025
@github-actions

github-actions Bot commented Mar 11, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f3d3fba
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/aacebcdc-984e-4cad-959b-b1ee80f94445

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Mar 11, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 304df29
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/944d033b-37a0-4a2a-a218-97e6c4fac806

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@wachunei wachunei force-pushed the feat/ramp-non-evm-balance branch from 03ef951 to 8638db2 Compare March 11, 2025 16:41
@github-actions

github-actions Bot commented Mar 12, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7bd7db7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e74073b6-0896-4c4b-97c2-be3e36fc6404

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Mar 12, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e2ddb4f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/54b1f519-39d2-4f4b-8424-3bd818c75a8f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@codecov-commenter

codecov-commenter commented Mar 12, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 63.99%. Comparing base (d1d22d7) to head (e2ddb4f).
Report is 74 commits behind head on main.

Files with missing lines Patch % Lines
app/components/UI/Ramp/hooks/useBalance.ts 0.00% 13 Missing ⚠️
...components/UI/Ramp/Views/BuildQuote/BuildQuote.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13948      +/-   ##
==========================================
+ Coverage   63.42%   63.99%   +0.56%     
==========================================
  Files        2093     2153      +60     
  Lines       45277    45929     +652     
  Branches     6234     6378     +144     
==========================================
+ Hits        28717    29390     +673     
+ Misses      14676    14632      -44     
- Partials     1884     1907      +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Mar 13, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 949247f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2d43403e-38da-4405-abda-700171122ca0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

wachunei
wachunei commented Mar 13, 2025
View reviewed changes
Comment thread app/components/UI/Ramp/hooks/useBalance.ts Outdated
@github-actions

github-actions Bot commented Mar 13, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 322dff6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/279abbb8-4180-4a49-9634-93c09b84c84d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

owencraston
owencraston reviewed Mar 13, 2025
View reviewed changes
Comment thread app/components/UI/Ramp/hooks/useBalance.ts
Comment thread app/components/UI/Ramp/hooks/useBalance.ts
@github-actions

github-actions Bot commented Mar 14, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e4ff826
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a36971ce-fefd-45d8-95cd-f3c42f000313

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Mar 17, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5c2162f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b030b62a-a70c-4aad-8701-daedad5401a6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

georgeweiler
georgeweiler previously approved these changes Mar 17, 2025
View reviewed changes
@wachunei wachunei marked this pull request as ready for review March 17, 2025 13:54
@wachunei wachunei requested a review from a team as a code owner March 17, 2025 13:54
tommasini
tommasini previously approved these changes Mar 17, 2025
View reviewed changes

@tommasini tommasini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dream feature

@wachunei wachunei dismissed stale reviews from tommasini and georgeweiler via d2e4037 March 17, 2025 15:35
@github-actions

github-actions Bot commented Mar 17, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d2e4037
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f64af0d9-2ccb-4f86-a75c-635216eef8ee

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@wachunei wachunei enabled auto-merge March 17, 2025 17:23
@sonarqubecloud

sonarqubecloud Bot commented Mar 17, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@wachunei wachunei added this pull request to the merge queue Mar 17, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 17, 2025
@wachunei wachunei added this pull request to the merge queue Mar 17, 2025
Merged via the queue into main with commit 2869e32 Mar 17, 2025
@wachunei wachunei deleted the feat/ramp-non-evm-balance branch March 17, 2025 18:52
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 17, 2025
@metamaskbot metamaskbot added the release-7.44.0 Issue or pull request that will be included in release 7.44.0 label Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@owencraston owencraston owencraston left review comments

@georgeweiler georgeweiler georgeweiler approved these changes

@tommasini tommasini tommasini approved these changes

Assignees

No one assigned

Labels

release-7.44.0 Issue or pull request that will be included in release 7.44.0 team-money-movement issues related to Money Movement features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wachunei @codecov-commenter @georgeweiler @owencraston @tommasini @metamaskbot