Skip to content

feat: bridge source token selector#13915

Merged
infiniteflower merged 49 commits into
mainfrom
mms1884-bridge-source-token-selector
Mar 17, 2025
Merged

feat: bridge source token selector#13915
infiniteflower merged 49 commits into
mainfrom
mms1884-bridge-source-token-selector

Conversation

@infiniteflower

@infiniteflower infiniteflower commented Mar 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR implements the source token selector for your current chain for Bridge.

It does not implement:

  1. Network selection
  2. Destination token selection

Related issues

Fixes:

Manual testing steps

  1. Add export MM_BRIDGE_UI_ENABLED="true" to .js.env
  2. Go to the Bridge page
  3. Click on the source token
  4. The bottom sheet should pop up

Screenshots/Recordings

Before

After

Screenshot 2025-03-11 at 6 51 05 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Mar 7, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Mar 7, 2025
@infiniteflower infiniteflower force-pushed the mms1884-bridge-source-token-selector branch 2 times, most recently from fc52762 to 2fb05f7 Compare March 11, 2025 19:52
Base automatically changed from mms-1885-bridge-input to main March 11, 2025 20:02
@infiniteflower infiniteflower force-pushed the mms1884-bridge-source-token-selector branch from 2fb05f7 to 5f178c9 Compare March 11, 2025 20:12
@infiniteflower infiniteflower changed the title Mms1884 bridge source token selector feat: bridge source token selector Mar 11, 2025
@github-actions

github-actions Bot commented Mar 11, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 46ad759
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6a39541a-ae4c-48e5-87fc-c03e13204431

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@infiniteflower
feat: show tokens with a balance in source selector
9f2409b
@infiniteflower
feat: show fiat value, name, symbol correctly
c1795ec
@infiniteflower
chore: small refactors
137d85a
@infiniteflower
feat: actually get source token selector to work
453d8d3
@infiniteflower
chore: simplify the icon image
3184e15
@infiniteflower
feat: get native asset to show
47e0b75
@infiniteflower
chore: just put hook into bridge folder
408b867
@infiniteflower
feat: load all tokens for that chain
8ef29ba
@infiniteflower
feat: conditionally display token balance and fiat value if they dont…
8481bf9 
… have balance
@infiniteflower
feat: close token selector on x press
d9ceed6
@infiniteflower
chore: format balance and fiat to correct decimals
ca9262c
@infiniteflower
feat: format token balances correctly, extract token selector item in…
703a3a8 
…to separate component for improved modularity
@infiniteflower
feat: add bottom badge positioning for token selector item
c80d521
@infiniteflower
WIP fixing source token stuff
f2870f7
@infiniteflower
chore: remove comment
e8bd5c6
@infiniteflower
fix: network badge not showing up in source selector
497430a
@infiniteflower
fix: native token icon not showing in source selector
f6264f4
@infiniteflower
chore: remove comment
2f28e96
@infiniteflower
chore: remove comment
8f23208
@infiniteflower
chore: move strings to en.json
35daf99
@infiniteflower
chore: clean up styles
02e0a41
@github-actions

github-actions Bot commented Mar 14, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c965e0c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/54d655d6-96ec-4087-a985-751d32c09e92

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

amitabh94
amitabh94 approved these changes Mar 14, 2025
View reviewed changes

@amitabh94 amitabh94 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions

github-actions Bot commented Mar 14, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4bbe7d6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ff37a89f-a922-41f0-969f-17ece58506cf

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented Mar 17, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8714722
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ded35a30-c8c4-4d02-b8f1-cc083476ae1d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter

codecov-commenter commented Mar 17, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 81.63265% with 18 lines in your changes missing coverage. Please review.

Project coverage is 64.49%. Comparing base (d1d22d7) to head (8714722).
Report is 103 commits behind head on main.

Files with missing lines Patch % Lines
app/components/UI/Bridge/useSourceTokens.ts 67.44% 0 Missing and 14 partials ⚠️
app/components/UI/Bridge/BridgeTokenSelector.tsx 96.42% 0 Missing and 1 partial ⚠️
app/components/UI/Bridge/TokenSelectorItem.tsx 90.00% 0 Missing and 1 partial ⚠️
app/components/UI/Bridge/index.tsx 0.00% 0 Missing and 1 partial ⚠️
app/core/redux/slices/bridge/index.ts 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13915      +/-   ##
==========================================
+ Coverage   63.42%   64.49%   +1.07%     
==========================================
  Files        2093     2183      +90     
  Lines       45277    46360    +1083     
  Branches     6234     6475     +241     
==========================================
+ Hits        28717    29900    +1183     
+ Misses      14676    14516     -160     
- Partials     1884     1944      +60

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

sonarqubecloud Bot commented Mar 17, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@infiniteflower infiniteflower added this pull request to the merge queue Mar 17, 2025
Merged via the queue into main with commit ba92a07 Mar 17, 2025
@infiniteflower infiniteflower deleted the mms1884-bridge-source-token-selector branch March 17, 2025 18:46
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 17, 2025
@metamaskbot metamaskbot added the release-7.44.0 Issue or pull request that will be included in release 7.44.0 label Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@amitabh94 amitabh94 amitabh94 approved these changes

@brianacnguyen brianacnguyen brianacnguyen approved these changes

@micaelae micaelae micaelae left review comments

Assignees

No one assigned

Labels

release-7.44.0 Issue or pull request that will be included in release 7.44.0 team-swaps-and-bridge Swaps and Bridge team team-swaps-deprecated DEPRECATED: please use "team-swaps-and-bridge" instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@infiniteflower @codecov-commenter @amitabh94 @brianacnguyen @micaelae @metamaskbot