Skip to content

chore: upgrade Xcode 16 on bitrise.yml#13807

Merged
sethkfman merged 4 commits into
mainfrom
chore/xcode-upgrade-bitrise
Mar 5, 2025
Merged

chore: upgrade Xcode 16 on bitrise.yml#13807
sethkfman merged 4 commits into
mainfrom
chore/xcode-upgrade-bitrise

Conversation

@sethkfman

@sethkfman sethkfman commented Mar 3, 2025

Copy link
Copy Markdown
Contributor

Description

This PR upgrades Xcode version to 16.

Related issues

Fixes:

Manual testing steps

  1. Run CI to confirm builds work

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sethkfman sethkfman requested a review from a team March 3, 2025 18:00
@github-actions

github-actions Bot commented Mar 3, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Mar 3, 2025
@sethkfman sethkfman linked an issue Mar 3, 2025 that may be closed by this pull request
Upgrade the iOS SDK version of the app #13725
Closed
9 tasks
@github-actions

github-actions Bot commented Mar 3, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 492cc69
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a382e151-a883-4d49-9587-3f2be8c639ef

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

andrepimenta
andrepimenta previously approved these changes Mar 3, 2025
View reviewed changes
@sethkfman
Update bitrise.yml
816411b 
Bumped to version 16.2
@github-actions

github-actions Bot commented Mar 3, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 816411b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6c7cbb90-2236-4faf-b9f8-bb372e519858

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sethkfman sethkfman enabled auto-merge March 5, 2025 17:29
@sonarqubecloud

sonarqubecloud Bot commented Mar 5, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sethkfman sethkfman added this pull request to the merge queue Mar 5, 2025
Merged via the queue into main with commit 4a89137 Mar 5, 2025
@sethkfman sethkfman deleted the chore/xcode-upgrade-bitrise branch March 5, 2025 18:09
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 5, 2025
@metamaskbot metamaskbot added the release-7.43.0 Issue or pull request that will be included in release 7.43.0 label Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrepimenta andrepimenta andrepimenta approved these changes

Assignees

No one assigned

Labels

release-7.43.0 Issue or pull request that will be included in release 7.43.0 team-mobile-platform Mobile Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade the iOS SDK version of the app

4 participants

@sethkfman @andrepimenta @gauthierpetetin @metamaskbot