Skip to content

feat: integrate blockaid alert into the Alert System#13744

Merged
vinistevam merged 86 commits into
mainfrom
feat/add-blockaid-alert
Mar 17, 2025
Merged

feat: integrate blockaid alert into the Alert System#13744
vinistevam merged 86 commits into
mainfrom
feat/add-blockaid-alert

Conversation

@vinistevam

@vinistevam vinistevam commented Feb 27, 2025

Copy link
Copy Markdown
Contributor

Description

This PR aims to integrate the blockaid alert into the Alert System only for Signatures.
This alert fires once the Security Alert API reply the request validation with result_type property with malicious or warning .

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/2148

Manual testing steps

  1. Go to Test dapp
  2. In the section PPOM - Malicious Transactions and Signatures click on all Signatures
  3. A banner should appear once you try to confirm the confirm modal so the users can acknowledge the risk and confirm or reject.

Transaction scenario
Transactions are using the old banner alert so it should work as before.

Screenshots/Recordings

blockaid.mp4

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinistevam vinistevam removed request for a team March 5, 2025 09:30
@MetaMask MetaMask deleted a comment from codecov-commenter Mar 5, 2025
Base automatically changed from feat/add-inline-alert to main March 5, 2025 14:59
Comment thread app/components/Views/confirmations/hooks/alerts/useBlockaidAlerts.test.tsx Outdated
digiwand
digiwand previously approved these changes Mar 8, 2025
@digiwand

digiwand commented Mar 8, 2025

Copy link
Copy Markdown
Contributor

Nice! can re-review/approve after merge conflicts are resolved

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: db9ea14
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/795f71cc-c81a-4a51-b5bb-073ccf719995

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinistevam vinistevam added this pull request to the merge queue Mar 17, 2025
Merged via the queue into main with commit 0c99a88 Mar 17, 2025
@vinistevam vinistevam deleted the feat/add-blockaid-alert branch March 17, 2025 09:26
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 17, 2025
@metamaskbot metamaskbot added the release-7.44.0 Issue or pull request that will be included in release 7.44.0 label Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.44.0 Issue or pull request that will be included in release 7.44.0 team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants