feat: integrate blockaid alert into the Alert System#13744
Merged
Conversation
…tamask-mobile into feat/add-alert-modal
digiwand
reviewed
Mar 8, 2025
digiwand
previously approved these changes
Mar 8, 2025
Contributor
|
Nice! can re-review/approve after merge conflicts are resolved |
digiwand
approved these changes
Mar 11, 2025
|
Contributor
|
jpuri
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR aims to integrate the blockaid alert into the Alert System only for Signatures.
This alert fires once the Security Alert API reply the request validation with
result_typeproperty withmaliciousorwarning.Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/2148
Manual testing steps
PPOM - Malicious Transactions and Signaturesclick on all SignaturesTransaction scenario
Transactions are using the old banner alert so it should work as before.
Screenshots/Recordings
blockaid.mp4
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist