Skip to content

chore(runway): cherry-pick Temporarily revert gas included swaps#13678

Merged
sethkfman merged 1 commit into
release/7.41.0from
cherry-pick-7f31286
Feb 22, 2025
Merged

chore(runway): cherry-pick Temporarily revert gas included swaps#13678
sethkfman merged 1 commit into
release/7.41.0from
cherry-pick-7f31286

Conversation

@runway-github

@runway-github runway-github Bot commented Feb 22, 2025

Copy link
Copy Markdown
Contributor

Description

Reverts #13430 for now.

We initially believed that resolving the known issue with gas-included
swaps requiring token approval would be easy and could be completed
before the release candidate for version 7.41.0 was pushed to
production, but it turns out that more fundamental changes are needed.
Specifically, submitBatch support from the
TransactionController—allowing the simultaneous submission of multiple
transactions (approval and swap)—is required. This submitBatch support
will likely also be used for current swaps that need token approval to
increase success rates.

Related issues

Fixes: #13584

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots. 7f31286

@runway-github runway-github Bot requested a review from a team as a code owner February 22, 2025 19:29
@runway-github runway-github Bot requested a review from a team February 22, 2025 19:29
@runway-github runway-github Bot requested a review from a team as a code owner February 22, 2025 19:29
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead label Feb 22, 2025
@sethkfman sethkfman added Run Smoke E2E and removed team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead labels Feb 22, 2025
@github-actions

github-actions Bot commented Feb 22, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f811e1f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53aec2fc-165d-42a8-91c7-7f9aef0a2354

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud

Copy link
Copy Markdown

@sethkfman sethkfman added the team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead label Feb 22, 2025

@sethkfman sethkfman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman merged commit d07d98d into release/7.41.0 Feb 22, 2025
@sethkfman sethkfman deleted the cherry-pick-7f31286 branch February 22, 2025 21:10
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants