Skip to content

fix: mobile crash issue during revoke with low gas#13655

Merged
vinistevam merged 4 commits intomainfrom
feat/app-crash-revoke
Feb 24, 2025
Merged

fix: mobile crash issue during revoke with low gas#13655
vinistevam merged 4 commits intomainfrom
feat/app-crash-revoke

Conversation

@vinistevam
Copy link
Copy Markdown
Contributor

@vinistevam vinistevam commented Feb 21, 2025 •
edited
Loading

Description

This PR will fix the mobile crash issue when a user performs a remove with a low gas or nonce. The PR removes the throw causing the unhandled promise to float until the default native error handler and adds a log to track the occurrences of this error which is likely happening between unsubscribing it and the registered listener throwing the error.

Related issues

Fixes: #11129

Manual testing steps

  1. Go to this page test dapp
  2. Deploy a 721 contract and mint
  3. Use the button Revoke
  4. on MM select custom config -> gas
  5. add very low values 21000 to trigger an RPC error
  6. Confirm the tx
  7. An alert should be shown but the app should not crash.

Screenshots/Recordings

revoke-app-crash.mp4

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinistevam vinistevam added the team-confirmations Push issues to confirmations team label Feb 21, 2025
@vinistevam vinistevam requested a review from a team as a code owner February 21, 2025 08:41
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 21, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 21, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7fa7c1e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6ef0299f-999b-42d0-9b2a-cf3cb7a26f8a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 21, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 81ad74a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/96ebe86c-0a12-493d-90da-f4384b3bb0d5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 62.68%. Comparing base (f49ffff) to head (81ad74a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...s/Views/confirmations/ApproveView/Approve/index.js 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #13655   +/-   ##
=======================================
  Coverage   62.68%   62.68%           
=======================================
  Files        2022     2022           
  Lines       44405    44406    +1     
  Branches     6030     6033    +3     
=======================================
+ Hits        27836    27837    +1     
+ Misses      14733    14731    -2     
- Partials     1836     1838    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 24, 2025

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 0b84e3f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ffae45d7-aea1-41f2-8914-145253284e09

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 24, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
66.7% Duplication on New Code

See analysis details on SonarQube Cloud

@vinistevam vinistevam added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit 1d6aeb9 Feb 24, 2025
42 of 43 checks passed
@vinistevam vinistevam deleted the feat/app-crash-revoke branch February 24, 2025 13:16
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

Assignees

No one assigned

Labels

release-7.42.0 Issue or pull request that will be included in release 7.42.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Crash Metamask App when call (token) Approve/Enable Function

5 participants

@vinistevam @codecov-commenter @jpuri @pedronfigueiredo @metamaskbot