chore: cherry-pick #13594 (feat: STAKE-934: integrate earn controller package into existing pooled staking hooks)#13612
Merged
Merged
Conversation
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> Fixed inconsistent APR value displayed throughout the application. Also fixed the annual rate tooltip not displaying the historic APY graph. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Fixes: [STAKE-946: [FE] Fix inconsistent pooled-staking vault APR](https://consensyssoftware.atlassian.net/browse/STAKE-946) The pooled-staking APR is displayed in the following place: - CTA for users that have never staked before contains APR. - Annual rate for those that have staked. - APR is displayed as the "weekly average APR" in the historic APR graph when clicking on the annual rate tooltip. - APR is displayed above the quick amount buttons when user hasn't entered a value yet. - APR is displayed as the "weekly average APR" in the historic APR graph when clicking on the tooltip. - The reward rate/annual rate displays the APR. <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] -->   <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/3c834e82-36f8-406c-8c0a-4d527b0c0db0 - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
MarioAslau
approved these changes
Feb 19, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/7.41.0 #13612 +/- ##
=================================================
Coverage ? 61.85%
=================================================
Files ? 1980
Lines ? 43948
Branches ? 5946
=================================================
Hits ? 27183
Misses ? 14961
Partials ? 1804 ☔ View full report in Codecov by Sentry. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR cherry-picks #13594