Skip to content

chore: cherry-pick #13514 (test: remove old permission system test)#13587

Merged
MarioAslau merged 1 commit into
release/7.41.0from
chore/cherry-pick-13514
Feb 18, 2025
Merged

chore: cherry-pick #13514 (test: remove old permission system test)#13587
MarioAslau merged 1 commit into
release/7.41.0from
chore/cherry-pick-13514

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

This PR cherry-picks #13514

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR removes an obsolete e2e test. Furthermore, the
CHAIN_PERMISSIONS: FALSE flag in the regression pipeline was removed
since chain permissions are on by default.

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@cortisiko cortisiko changed the title chore: cherry-pick #13514 chore: cherry-pick #13514 (test: remove old permission system test) Feb 18, 2025
@cortisiko cortisiko marked this pull request as ready for review February 18, 2025 17:25
@cortisiko cortisiko requested a review from a team February 18, 2025 17:25
@cortisiko cortisiko requested a review from a team as a code owner February 18, 2025 17:25
@MarioAslau MarioAslau merged commit 171a2be into release/7.41.0 Feb 18, 2025
@MarioAslau MarioAslau deleted the chore/cherry-pick-13514 branch February 18, 2025 19:23
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants