Skip to content

feat: bridge tx submission#13577

Merged
bfullam merged 64 commits into
mainfrom
MMS-1889-native-gas-token-bridge-tx-submission
Mar 17, 2025
Merged

feat: bridge tx submission#13577
bfullam merged 64 commits into
mainfrom
MMS-1889-native-gas-token-bridge-tx-submission

Conversation

@bfullam

@bfullam bfullam commented Feb 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR implements the following:

  1. Submit bridge transaction for native gas tokens that don't require approval
  2. Submit bridge transaction for ERC20s (with or without required approval)

Related issues

Fixes:

Manual testing steps

Outside app

  1. Get quote from bridge API (e.g. Eth USDC -> Arb USDC, but make sure to put in your own wallet address)
  2. Copy first object from resulting array.
  3. Paste object in code, on line 161 of app/components/UI/Bridge/index.tsx

In app

  1. Go to bridge page
  2. Enter any sufficient amount of any token, just to reveal "continue" button
  3. Click "continue"
  4. Wait and check for expected bridge results

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Feb 18, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-identity-deprecated DEPRECATED: team no longer exists label Feb 18, 2025
@bfullam bfullam added team-swaps-deprecated DEPRECATED: please use "team-swaps-and-bridge" instead Run Smoke E2E and removed team-identity-deprecated DEPRECATED: team no longer exists labels Feb 18, 2025
@github-actions

github-actions Bot commented Feb 18, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2581322
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7b38ee34-fb6b-4ace-8c83-427a8e5c79b2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@bfullam bfullam changed the title Mms 1889 native gas token bridge tx submission feat: native gas token bridge tx submission Feb 18, 2025
@codecov-commenter

codecov-commenter commented Feb 20, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 27.27273% with 32 lines in your changes missing coverage. Please review.

Project coverage is 63.43%. Comparing base (256bc97) to head (adeef17).
Report is 46 commits behind head on main.

Files with missing lines Patch % Lines
app/util/bridge/hooks/useHandleTx.ts 5.26% 18 Missing ⚠️
app/util/bridge/hooks/useHandleApprovalTx.ts 22.22% 7 Missing ⚠️
app/util/bridge/hooks/useHandleBridgeTx.ts 0.00% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13577      +/-   ##
==========================================
+ Coverage   62.91%   63.43%   +0.52%     
==========================================
  Files        2035     2100      +65     
  Lines       44539    45348     +809     
  Branches     6050     6243     +193     
==========================================
+ Hits        28020    28767     +747     
- Misses      14685    14699      +14     
- Partials     1834     1882      +48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

infiniteflower
infiniteflower reviewed Mar 12, 2025
View reviewed changes
Comment thread app/components/UI/Bridge/types.ts
infiniteflower
infiniteflower reviewed Mar 12, 2025
View reviewed changes
Comment thread app/util/bridge/hooks/useHandleTx.ts
infiniteflower
infiniteflower reviewed Mar 12, 2025
View reviewed changes
Comment thread app/util/bridge/hooks/useHandleApprovalTx.ts Outdated
@amitabh94 amitabh94 added team-swaps-and-bridge Swaps and Bridge team and removed team-swaps-deprecated DEPRECATED: please use "team-swaps-and-bridge" instead labels Mar 12, 2025
@github-actions

github-actions Bot commented Mar 13, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: c0d0570
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f913362e-b0d1-43dc-bc94-eac3eec202c2

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Mar 13, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Mar 13, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: aec388d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8592e2c2-b9c4-426b-a2f1-de6f0d90c871

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

infiniteflower
infiniteflower approved these changes Mar 13, 2025
View reviewed changes

@infiniteflower infiniteflower left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a few non-STX and it seems to be working

amitabh94
amitabh94 approved these changes Mar 14, 2025
View reviewed changes

@amitabh94 amitabh94 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bfullam bfullam added this pull request to the merge queue Mar 14, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 14, 2025
@bfullam bfullam added this pull request to the merge queue Mar 17, 2025
Merged via the queue into main with commit 52a4baf Mar 17, 2025
@bfullam bfullam deleted the MMS-1889-native-gas-token-bridge-tx-submission branch March 17, 2025 09:57
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 17, 2025
@metamaskbot metamaskbot added the release-7.44.0 Issue or pull request that will be included in release 7.44.0 label Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@amitabh94 amitabh94 amitabh94 approved these changes

@infiniteflower infiniteflower infiniteflower approved these changes

Assignees

No one assigned

Labels

release-7.44.0 Issue or pull request that will be included in release 7.44.0 team-swaps-and-bridge Swaps and Bridge team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bfullam @codecov-commenter @amitabh94 @infiniteflower @metamaskbot