Skip to content

chore: cherry-pick #13530#13532

Merged
MarioAslau merged 1 commit into
release/7.41.0from
chore/cherry-pick-13530
Feb 14, 2025
Merged

chore: cherry-pick #13530#13532
MarioAslau merged 1 commit into
release/7.41.0from
chore/cherry-pick-13530

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

This PR cherry-picks #13530

## **Description**

update plist to include CFBundleIconName for app icons

## **Related issues**

Fixes:

## **Manual testing steps**

1. View `ios/MetaMask/Info.plist` to confirm `CFBundleIconName` is there
2.
3.

## **Screenshots/Recordings**

NA

### **Before**

NA

### **After**

NA

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@MarioAslau MarioAslau marked this pull request as ready for review February 14, 2025 19:06
@MarioAslau MarioAslau requested a review from a team as a code owner February 14, 2025 19:06
@MarioAslau MarioAslau merged commit 13301f0 into release/7.41.0 Feb 14, 2025
@MarioAslau MarioAslau deleted the chore/cherry-pick-13530 branch February 14, 2025 19:17
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants