Skip to content

fix: cp-7.41.0 fix main aggregated account balance#13513

Merged
sahar-fehri merged 2 commits into
mainfrom
fix/fix-main-total-account-balance
Feb 14, 2025
Merged

fix: cp-7.41.0 fix main aggregated account balance#13513
sahar-fehri merged 2 commits into
mainfrom
fix/fix-main-total-account-balance

Conversation

@sahar-fehri

@sahar-fehri sahar-fehri commented Feb 14, 2025

Copy link
Copy Markdown
Contributor

Description

fixes main aggregated balance

Related issues

Fixes: #13478

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Feb 14, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. Run Smoke E2E labels Feb 14, 2025
@github-actions

github-actions Bot commented Feb 14, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: fadc8c9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e0968b28-01eb-42b2-b9a6-e70528f54d9f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sleepytanya

sleepytanya commented Feb 14, 2025

Copy link
Copy Markdown
Contributor

@sahar-fehri

Builds: https://app.bitrise.io/build/5e1c8dc2-334d-486f-be04-3152b8c1f142?tab=artifacts
Balance looks good for all networks except Linea:

linea_balance.mp4

@sahar-fehri sahar-fehri marked this pull request as ready for review February 14, 2025 09:37
@sahar-fehri sahar-fehri requested a review from a team as a code owner February 14, 2025 09:37
@github-actions

github-actions Bot commented Feb 14, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f35e521
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/953e1659-f0ea-475b-ace3-0162d4632592

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Feb 14, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sahar-fehri
sahar-fehri commented Feb 14, 2025
View reviewed changes
Comment thread app/selectors/tokensController.ts
@sahar-fehri sahar-fehri changed the title fix: fix main aggregated account balance fix: cp-7.41.0 fix main aggregated account balance Feb 14, 2025
@sleepytanya

sleepytanya commented Feb 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@sahar-fehri

Build: https://app.bitrise.io/build/06f4cca3-68ac-4e72-8e61-5db934886dd6?tab=artifacts
Fixed in the latest commit:

Screen_Recording_20250214_101243_MetaMask.mp4

@sleepytanya sleepytanya added the QA Passed QA testing has been completed and passed label Feb 14, 2025
@sahar-fehri sahar-fehri added this pull request to the merge queue Feb 14, 2025
Merged via the queue into main with commit caa5cde Feb 14, 2025
@sahar-fehri sahar-fehri deleted the fix/fix-main-total-account-balance branch February 14, 2025 15:37
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 14, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@salimtb salimtb salimtb approved these changes

@tommasini tommasini tommasini approved these changes

Assignees

No one assigned

Labels

needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. QA Passed QA testing has been completed and passed release-7.42.0 Issue or pull request that will be included in release 7.42.0 team-assets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: When in the "Popular Networks" view, the overall displayed balance does not align with the aggregate value of the assets listed

5 participants

@sahar-fehri @sleepytanya @salimtb @tommasini @metamaskbot