Skip to content

chore: remove SRP videos#13507

Merged
Cal-L merged 2 commits into
mainfrom
update-srp-onboarding-asset
Feb 14, 2025
Merged

chore: remove SRP videos#13507
Cal-L merged 2 commits into
mainfrom
update-srp-onboarding-asset

Conversation

@vinnyhoward

@vinnyhoward vinnyhoward commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Description

Removing the SRP video (saving 7.5 mb) and replaced with new designs here In the future we are doing a bigger redesign. This is a small step towards it

Related issues

Fixes:

Manual testing steps

  1. Fresh install of the app
  2. Create a new wallet and going through onboarding flow, make sure the new design is there and fits on all devices
  3. Afterwards goto settings and goto "Security and Privacy" to make sure its removed altogether (no design)

Screenshots/Recordings

Larger Devices

iPhone 16

Smaller Devices

iPhone SE

after-iPhone-SE.mp4

Pixel 2

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinnyhoward vinnyhoward requested review from a team as code owners February 13, 2025 21:44
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-core-extension-ux Core Extension UX team label Feb 13, 2025
@github-actions

github-actions Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 196e52f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1e476937-abc4-4453-9e87-a0224455b613

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

Copy link
Copy Markdown

@vinnyhoward vinnyhoward changed the title update: remove SRP videos chore: remove SRP videos Feb 13, 2025

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 1 comment

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit a1d4e5f Feb 14, 2025
@Cal-L Cal-L deleted the update-srp-onboarding-asset branch February 14, 2025 00:05
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 14, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.42.0 Issue or pull request that will be included in release 7.42.0 team-core-extension-ux Core Extension UX team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants