Skip to content

chore: bump walletconnect/* deps#12345

Merged
christopherferreira9 merged 5 commits intomainfrom
wcsdk
Nov 28, 2024
Merged

chore: bump walletconnect/* deps#12345
christopherferreira9 merged 5 commits intomainfrom
wcsdk

Conversation

@abretonc7s
Copy link
Copy Markdown
Contributor

@abretonc7s abretonc7s commented Nov 20, 2024

Description

Update to latest walletconnect dependencies.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@abretonc7s
chore: bump @WalletConnect dependencies
ded2b4b 
Updated @walletconnect/se-sdk to 1.11.0 and other related dependencies in yarn.lock
@abretonc7s
chore: bump @walletconnect/* deps
5cc9ad8
@abretonc7s abretonc7s added the team-sdk-deprecated DEPRECATED: please use "team-wallet-integrations" instead label Nov 20, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 20, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@abretonc7s abretonc7s added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Nov 20, 2024
@socket-security
Copy link
Copy Markdown

socket-security bot commented Nov 20, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@reown/walletkit@1.1.1 None 0 3.32 MB gancho_walletconnect
npm/@walletconnect/se-sdk@1.11.0 None 0 9.82 MB gancho_walletconnect
npm/@walletconnect/sign-client@2.17.1 None 0 3.78 MB gancho_walletconnect
npm/elliptic@6.6.0 None 0 120 kB indutny

🚮 Removed packages: npm/@walletconnect/auth-client@2.1.2, npm/@walletconnect/se-sdk@1.10.0, npm/@walletconnect/sign-client@2.15.0, npm/@walletconnect/web3wallet@1.14.0, npm/isomorphic-unfetch@3.1.0

View full report↗︎

@abretonc7s abretonc7s marked this pull request as ready for review November 20, 2024 04:14
@abretonc7s abretonc7s requested a review from a team as a code owner November 20, 2024 04:14
@abretonc7s abretonc7s requested a review from a team November 20, 2024 04:14
@abretonc7s abretonc7s requested a review from a team as a code owner November 20, 2024 04:14
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.36%. Comparing base (22a4989) to head (d6b4d9f).
Report is 13 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #12345      +/-   ##
==========================================
- Coverage   56.41%   56.36%   -0.05%     
==========================================
  Files        1797     1800       +3     
  Lines       40586    40594       +8     
  Branches     5097     5103       +6     
==========================================
- Hits        22896    22881      -15     
- Misses      16134    16147      +13     
- Partials     1556     1566      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@christopherferreira9 christopherferreira9 added QA in Progress QA has started on the feature. QA Passed QA testing has been completed and passed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. QA in Progress QA has started on the feature. labels Nov 26, 2024
@christopherferreira9
Copy link
Copy Markdown
Contributor

christopherferreira9 commented Nov 26, 2024

This is good for QA.
Test cases (applicable for Android and iOS):

Given I navigate to https://app.uniswap.org/ 
And I'm using a mobile device
When I connect
Then I should be deeplinked to MetaMask and a connection should popup


Given I am connected to https://app.uniswap.org/ 
And I'm using a mobile device
When I submit a transaction
Then I should be deeplinked to MetaMask and a transaction request should popup 

Given I navigate to https://app.uniswap.org/ 
And I'm using a Desktop device
When I Scan the QR code on the dapp
Then  a connection should popup


Given I am connected to https://app.uniswap.org/ 
And I'm using a Desktop device
When I submit a transaction
Then  a transaction request should popup in MetaMask

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 28, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 165ccb6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0691ff03-bd10-4be8-855b-bc4d136aab7c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@christopherferreira9 christopherferreira9 added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit a4f928a Nov 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tommasini tommasini tommasini approved these changes

Assignees

No one assigned

Labels

QA Passed QA testing has been completed and passed release-7.37.0 Issue or pull request that will be included in release 7.37.0 team-sdk-deprecated DEPRECATED: please use "team-wallet-integrations" instead

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@abretonc7s @codecov-commenter @christopherferreira9 @tommasini @metamaskbot