Skip to content

feat: Simulation re-trigger#12073

Merged
NicolasMassart merged 14 commits intorelease/7.33.1from
fix/3380-simulation-retrigger
Oct 30, 2024
Merged

feat: Simulation re-trigger#12073
NicolasMassart merged 14 commits intorelease/7.33.1from
fix/3380-simulation-retrigger

Conversation

@OGPoyraz
Copy link
Copy Markdown
Member

@OGPoyraz OGPoyraz commented Oct 29, 2024 •
edited
Loading

Description

This PR aims to add re-simulation logic which recently added at MetaMask/core#4792

Patch note:
Transaction controller patch adds the re-simulate feature, branched belove to keep track - this will eventually be removed in subsequent releases.
MetaMask/core@main...patch/mobile-transaction-controller-35-0-0

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3380

Manual testing steps

Since the changes are in the core - it's already validated in the extension in the transaction lifecycle.

But for the sake of risk, all transaction simulations will be rechecked and approval will be needed from QA as we discussed internally.

Screenshots/Recordings

Simulator.Screen.Recording.-.iPhone.13.Pro.-.2024-10-29.at.14.15.02.mp4

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Oct 29, 2024
@OGPoyraz OGPoyraz added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Oct 29, 2024
OGPoyraz
OGPoyraz commented Oct 29, 2024
View reviewed changes
@OGPoyraz OGPoyraz changed the title [WIP] feat: Simulation re-trigger feat: Simulation re-trigger Oct 29, 2024
@OGPoyraz OGPoyraz marked this pull request as ready for review October 29, 2024 12:34
@OGPoyraz OGPoyraz requested a review from a team as a code owner October 29, 2024 12:34
@OGPoyraz OGPoyraz requested a review from a team October 29, 2024 12:34
@OGPoyraz OGPoyraz requested a review from a team as a code owner October 29, 2024 12:34
matthewwalsh0
matthewwalsh0 requested changes Oct 29, 2024
View reviewed changes
NicolasMassart
NicolasMassart reviewed Oct 29, 2024
View reviewed changes
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 64.00000% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/7.33.1@0302b52). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...p/components/Views/confirmations/Approval/index.js 10.00% 9 Missing ⚠️
Additional details and impacted files 
@@                Coverage Diff                @@
##             release/7.33.1   #12073   +/-   ##
=================================================
  Coverage                  ?   53.99%           
=================================================
  Files                     ?     1647           
  Lines                     ?    38337           
  Branches                  ?     4672           
=================================================
  Hits                      ?    20699           
  Misses                    ?    16208           
  Partials                  ?     1430

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
33.3% Coverage on New Code (required ≥ 60%)
18.2% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud

@sethkfman sethkfman added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Oct 30, 2024
@sethkfman
Copy link
Copy Markdown
Contributor

sethkfman commented Oct 30, 2024

Considering the manual test evidence. I am okay moving forward with an override. I would like to see an issue created to support modal unit testing for these scenarios. @OGPoyraz

@NicolasMassart NicolasMassart merged commit a8eaa56 into release/7.33.1 Oct 30, 2024
@NicolasMassart NicolasMassart deleted the fix/3380-simulation-retrigger branch October 30, 2024 17:01
@github-actions github-actions bot removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Oct 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
@sleepytanya
Copy link
Copy Markdown
Contributor

sleepytanya commented Oct 30, 2024 •
edited
Loading

Bitrise builds:

https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4469c953-368c-49aa-b322-850019994581?tab=workflows

https://app.bitrise.io/build/4a80f97e-7cee-49ba-b0c0-d3b0e150ce5c?tab=log

The fix has been implemented successfully. However, we experienced a challenge with the iOS build on Bitrise, which prevented testing the functionality on a physical device. Despite this, the local iOS build operates as anticipated.

Screen_Recording_20241029_113830_MetaMask.mp4
last.mp4

In iOS Bitrise build all transaction action are disabled and other errors not related to the current PR are present as well, for example the error you get when trying to access networks modal:

IMG_0256

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NicolasMassart NicolasMassart NicolasMassart left review comments

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

Assignees

No one assigned

Labels

skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@OGPoyraz @codecov-commenter @sethkfman @sleepytanya @NicolasMassart @matthewwalsh0