Skip to content

fix: ethereumjs-util -> @ethereumjs/util@^8.1.0#11979

Closed
legobeat wants to merge 10 commits intomainfrom
deps-ethereumjs-util-8
Closed

fix: ethereumjs-util -> @ethereumjs/util@^8.1.0#11979
legobeat wants to merge 10 commits intomainfrom
deps-ethereumjs-util-8

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented Oct 23, 2024 •
edited by NicolasMassart
Loading

Description

Replaces legacy ethereumjs-util with maintained @ethereumjs/util.

Related issues

Based on

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 23, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-application-security Application security team Run Smoke E2E and removed team-lavamoat labels Oct 23, 2024
@legobeat legobeat changed the title deps: ethereumjs-util@^6.2.0->@ethereumjs/util@^8.1.0 fix ethereumjs-util@^6.2.0->@ethereumjs/util@^8.1.0 Oct 23, 2024
@socket-security
Copy link
Copy Markdown

socket-security bot commented Oct 23, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/bn.js@5.1.6 None 0 13.9 kB types
npm/ethereumjs-abi@0.6.8 None +2 214 kB holgerd77

🚮 Removed packages: npm/@types/bn.js@5.1.5, npm/bindings@1.5.0, npm/bip66@1.1.5, npm/drbg.js@1.0.1, npm/ethereumjs-abi@0.6.6, npm/file-uri-to-path@1.0.0

View full report↗︎

@legobeat legobeat changed the title fix ethereumjs-util@^6.2.0->@ethereumjs/util@^8.1.0 fix: ethereumjs-util@^6.2.0->@ethereumjs/util@^8.1.0 Oct 23, 2024
@legobeat legobeat mentioned this pull request Oct 23, 2024
Closed
8 tasks
@MetaMask MetaMask deleted a comment from github-actions bot Oct 23, 2024
@legobeat legobeat force-pushed the deps-ethereumjs-util-8 branch from 3c97a52 to 88144dc Compare October 23, 2024 14:40
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 88144dc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9aee9078-b4fe-4249-ac78-c02e266e4b86

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat force-pushed the deps-ethereumjs-util-8 branch from 88144dc to a6e2bb1 Compare October 24, 2024 17:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 24, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a6e2bb1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e925c1a0-778f-4171-94ce-b2edbfbd7e81

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat force-pushed the deps-ethereumjs-util-8 branch from a6e2bb1 to bbedc78 Compare October 25, 2024 01:07
@legobeat legobeat marked this pull request as ready for review October 25, 2024 01:08
@legobeat legobeat requested review from a team as code owners October 25, 2024 01:08
@legobeat legobeat requested a review from a team October 25, 2024 01:08
@legobeat legobeat requested review from a team as code owners October 25, 2024 01:08
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 28, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 67d4e9f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/93ab4ee7-0028-4635-ac0f-6210d0baef1c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat force-pushed the deps-ethereumjs-util-8 branch from 67d4e9f to bb6feb9 Compare October 29, 2024 19:50
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 29, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
78.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@legobeat legobeat mentioned this pull request Oct 29, 2024
Closed
12 tasks
@NicolasMassart NicolasMassart self-assigned this Dec 3, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 3, 2025

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Mar 3, 2025
@NicolasMassart NicolasMassart added team-mobile-platform Mobile Platform team and removed stale Issues that have not had activity in the last 90 days labels Mar 7, 2025
@NicolasMassart NicolasMassart marked this pull request as draft March 7, 2025 13:21
@NicolasMassart
Copy link
Copy Markdown
Contributor

NicolasMassart commented Mar 7, 2025

must be reworked after both #11932 and #11972 are merged

@NicolasMassart NicolasMassart moved this from Needs dev review to Needs more work from the author in PR review queue Mar 7, 2025
@NEllusion NEllusion added team-lavamoat and removed team-application-security Application security team labels Sep 25, 2025
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 25, 2025
@NicolasMassart
Copy link
Copy Markdown
Contributor

NicolasMassart commented Oct 22, 2025

This PR is obsolete now

@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@NicolasMassart NicolasMassart

Labels

dependencies Pull requests that update a dependency file external-contributor INVALID-PR-TEMPLATE PR's body doesn't match template team-lavamoat team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@legobeat @NicolasMassart @NEllusion @metamaskbot