fix: support for batch of signature requests#11729
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11729 +/- ##
==========================================
+ Coverage 54.27% 54.34% +0.07%
==========================================
Files 1711 1714 +3
Lines 38712 39102 +390
Branches 4738 4843 +105
==========================================
+ Hits 21010 21250 +240
- Misses 16253 16367 +114
- Partials 1449 1485 +36 ☔ View full report in Codecov by Sentry. |
|
Description
This PR addresses the issue of multiple signature popups being triggered sequentially on Mobile, which could lead to potential spam or overwhelm the user. Currently, multiple signature requests appear one after the other, even if the user accepts or rejects them. To align with the existing behavior for transactions, this PR removes signatures from the rate-limiting exclusions, ensuring that only one signature request is triggered at a time, preventing spam-like behavior until a proper queuing system is introduced on Mobile.
Related issues
Fixes: #8771
Manual testing steps
Screenshots/Recordings
sign.one.webm
Example of the current behaviour of batch 10 transactions:
transaction.one.webm
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist