Skip to content

chore: Remove eth-sign#11246

Merged
OGPoyraz merged 10 commits intomainfrom
chore/remove-eth-sign
Sep 18, 2024
Merged

chore: Remove eth-sign#11246
OGPoyraz merged 10 commits intomainfrom
chore/remove-eth-sign

Conversation

@OGPoyraz
Copy link
Copy Markdown
Member

@OGPoyraz OGPoyraz commented Sep 17, 2024 •
edited
Loading

Description

We recently removed eth_sign operations from extension: MetaMask/metamask-extension#24756
This PR aims to remove eth_sign and all related components from mobile. Also updates @metamask/signature-controller@17.0.0.

Notes

  • Removes keyring-controller patch (patch branch) because it's already addressed in @metamask/keyring-controller@16.1.0 here .

Related issues

Fixes: N/A

Manual testing steps

  1. Go to the [e2e test dapp] in-app browser (https://metamask.github.io/test-dapp/)
  2. Connect the wallet
  3. Scroll down to the Eth Sign card (https://metamask.github.io/test-dapp/#ethSign)
  4. Click Sign
  5. You should see Error: The method "eth_sign" does not exist / is not available.

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Sep 17, 2024
@socket-security
Copy link
Copy Markdown

socket-security bot commented Sep 17, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/keyring-controller@16.1.0 None 0 507 kB metamaskbot
npm/@metamask/message-manager@9.0.0 None 0 272 kB metamaskbot
npm/@metamask/signature-controller@17.0.0 None 0 221 kB metamaskbot

🚮 Removed packages: npm/@metamask/keyring-controller@16.0.0, npm/@metamask/message-manager@8.0.2, npm/@metamask/signature-controller@16.0.0

View full report↗︎

@OGPoyraz OGPoyraz added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Sep 17, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.57%. Comparing base (7475ab4) to head (f6a39d2).
Report is 30 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11246      +/-   ##
==========================================
+ Coverage   55.24%   55.57%   +0.32%     
==========================================
  Files        1558     1570      +12     
  Lines       37153    37367     +214     
  Branches     4406     4456      +50     
==========================================
+ Hits        20527    20765     +238     
+ Misses      16155    16111      -44     
- Partials      471      491      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OGPoyraz OGPoyraz marked this pull request as ready for review September 17, 2024 10:15
@OGPoyraz OGPoyraz requested a review from a team as a code owner September 17, 2024 10:15
@OGPoyraz OGPoyraz requested a review from a team September 17, 2024 10:15
@OGPoyraz OGPoyraz requested review from a team as code owners September 17, 2024 10:15
OGPoyraz
OGPoyraz commented Sep 17, 2024
View reviewed changes
@sleepytanya sleepytanya added the QA Passed QA testing has been completed and passed label Sep 17, 2024
@sleepytanya
Copy link
Copy Markdown
Contributor

sleepytanya commented Sep 17, 2024

Bitrise builds https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cb2f28e4-0ade-47b3-9cff-f9387b3f564d?tab=artifacts

Signatures work as expected (signatures regression passed).

Screenshot 2024-09-17 at 10 50 04

iOS:

ios.mov

Android:

android.mp4

@OGPoyraz OGPoyraz removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Sep 18, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Sep 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

NicolasMassart
NicolasMassart approved these changes Sep 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You gave my ethsign friction code a quick death, it had no time to suffer, thank you!

@OGPoyraz OGPoyraz added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit 9121a8b Sep 18, 2024
@OGPoyraz OGPoyraz deleted the chore/remove-eth-sign branch September 18, 2024 12:39
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
@metamaskbot metamaskbot added the release-7.32.0 Issue or pull request that will be included in release 7.32.0 label Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NicolasMassart NicolasMassart NicolasMassart approved these changes

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

Assignees

No one assigned

Labels

QA Passed QA testing has been completed and passed release-7.32.0 Issue or pull request that will be included in release 7.32.0 team-confirmations Push issues to confirmations team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@OGPoyraz @codecov-commenter @sleepytanya @NicolasMassart @matthewwalsh0 @metamaskbot