Skip to content

fix: disabled what's new modal#10588

Merged
vinnyhoward merged 14 commits intomainfrom
fix-2614-disable-whats-new-modal
Aug 20, 2024
Merged

fix: disabled what's new modal#10588
vinnyhoward merged 14 commits intomainfrom
fix-2614-disable-whats-new-modal

Conversation

@vinnyhoward
Copy link
Copy Markdown
Contributor

@vinnyhoward vinnyhoward commented Aug 12, 2024

Description

This PR disables the What's New modal in the mobile app. The change is made to improve user experience by removing a potentially disruptive and repetitive element.

  1. Reason for the change:

    • The What's New modal was found to be disruptive to user experience.
    • It became repetitive for frequent users.
    • Its functionality now overlaps with new features like the notification system and opt-in prompts.

  2. Improvement/solution:

    • Removed navigation logic to the What's New modal.
    • Added explanatory comments in the code for future reference.
    • The modal is now disabled, allowing for a smoother user experience while retaining the component for potential future use.

Related issues

Fixes: #2614

Manual testing steps

  1. Open the app as a new user.
  2. Verify that the What's New modal does not appear.
  3. Open the app as an existing user.
  4. Verify that the What's New modal does not appear.
  5. Navigate through the app to ensure no unexpected side effects from this change.

Screenshots/Recordings

Before After
before after

Before

  • See Screenshots/Recordings section

After

  • See Screenshots/Recordings section

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinnyhoward vinnyhoward requested a review from a team as a code owner August 12, 2024 23:44
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 12, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 12, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7475f29
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a020e956-d0d0-4645-af3f-696b0b2aa311

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.05%. Comparing base (de5ca5f) to head (d413d29).
Report is 10 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10588      +/-   ##
==========================================
+ Coverage   51.03%   51.05%   +0.01%     
==========================================
  Files        1517     1518       +1     
  Lines       36284    36289       +5     
  Branches     4199     4199              
==========================================
+ Hits        18518    18527       +9     
+ Misses      16560    16556       -4     
  Partials     1206     1206

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 13, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 66faebc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/da3b9e33-8c19-4434-9bbb-61c4ca47392e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 14, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6f947c5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dbe35979-0f7a-4b12-b1ef-1341ff5a32a9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 14, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 56bb96a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0f1d6d46-64e0-408e-8a45-5163bd636ce4

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 15, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 060c48c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fb6a10e9-6696-4810-a796-b25121a75dbb

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 15, 2024

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 83ebbfb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/919e15a3-4f8b-4dc6-80b8-8c4223da1950

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 15, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a33a329
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c8eda540-45f1-4047-87e9-6209bb01c1ab

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 16, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 915ca68
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/47180941-425e-4dcf-9e08-5d2cf2ad6276

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 16, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@vinnyhoward vinnyhoward added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild labels Aug 16, 2024
gambinish
gambinish approved these changes Aug 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@gambinish gambinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a fresh install of the mobile app and did not see the "What's New" modal so this LGTM ✅

@vinnyhoward vinnyhoward merged commit e92d1c3 into main Aug 20, 2024
@vinnyhoward vinnyhoward deleted the fix-2614-disable-whats-new-modal branch August 20, 2024 15:23
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 20, 2024
@metamaskbot metamaskbot added the release-7.30.0 Issue or pull request that will be included in release 7.30.0 label Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@brianacnguyen brianacnguyen brianacnguyen approved these changes

@gambinish gambinish gambinish approved these changes

Assignees

No one assigned

Labels

release-7.30.0 Issue or pull request that will be included in release 7.30.0 Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild team-core-extension-ux Core Extension UX team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vinnyhoward @codecov-commenter @brianacnguyen @gambinish @metamaskbot