Skip to content

chore: Patch GasFeeController to revert API URL#10044

Merged
tommasini merged 3 commits intomainfrom
kylan/patch-gas-fee-controller-2
Jun 20, 2024
Merged

chore: Patch GasFeeController to revert API URL#10044
tommasini merged 3 commits intomainfrom
kylan/patch-gas-fee-controller-2

Conversation

@smilingkylan
Copy link
Copy Markdown
Contributor

@smilingkylan smilingkylan commented Jun 19, 2024 •
edited by tommasini
Loading

Description

  1. There is a caching issue with some of the GasFeeController API URLs. The decision has been made to patch it for the time being.

Mobile Core issue: https://github.com/orgs/MetaMask/projects/60/views/6?pane=issue&itemId=67345155
Slack conversation: https://consensys.slack.com/archives/C01V1L10W2E/p1718117049087139
Similar PR for Extension: MetaMask/metamask-extension#25230
Core PR: MetaMask/core#4403
Core branch: patch/extension-gas-api-endpoint

Related issues

Fixes: https://github.com/orgs/MetaMask/projects/60/views/6?pane=issue&itemId=67345155

Manual testing steps

  1. Go to app and make sure gas fees are being calculated correctly.

Screenshots/Recordings

Before

gaspricecontroller-before.mov

After

gaspricecontroller-after.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 19, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 19, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1670c99
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/be553778-da28-4381-87f9-54a61013445d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jun 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@smilingkylan smilingkylan marked this pull request as ready for review June 20, 2024 10:52
@smilingkylan smilingkylan requested a review from a team June 20, 2024 10:52
@smilingkylan smilingkylan requested a review from a team as a code owner June 20, 2024 10:52
dbrans
dbrans reviewed Jun 20, 2024
View reviewed changes
@tommasini tommasini merged commit 8912e91 into main Jun 20, 2024
@tommasini tommasini deleted the kylan/patch-gas-fee-controller-2 branch June 20, 2024 14:47
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
@metamaskbot metamaskbot added the release-7.26.0 Issue or pull request that will be included in release 7.26.0 label Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tommasini tommasini tommasini approved these changes

+1 more reviewer

@dbrans dbrans dbrans approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-7.26.0 Issue or pull request that will be included in release 7.26.0 team-mobile-platform Mobile Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@smilingkylan @dbrans @tommasini @metamaskbot