Skip to content

fix: add identify metrics call at metrics instance setup #8885

@NicolasMassart

Description

@NicolasMassart

What is this about?

In segment, in order to improve user props update, identification is expected as soon as possible. We currently only do it when optin and not at app start when user is already optin.
We may miss some properties updated.

Scenario

No response

Design

No response

Technical Details

add identify in the Metametrics.configure after metametricsId is ready

Threat Modeling Framework

No response

Acceptance Criteria

  • check identify is sent at app startup only when user has metrics enabled.
  • when metrics disabled, no identify and no track should be sent.
  • unit test updated if needed.

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

https://github.com/MetaMask/metamask-mobile/blob/main/app/core/Analytics/MetaMetrics.ts#L512-L529

Metadata

Metadata

Labels

release-7.18.0Issue or pull request that will be included in release 7.18.0team-mobile-platformMobile Platform team

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions