-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[Bug] Gas is not re-calculated when updating a transaction #5865
Copy link
Copy link
Closed
Labels
Sev2-normalAn issue that may lead to users misunderstanding some limited risks they are takingAn issue that may lead to users misunderstanding some limited risks they are takingarea-gasteam-confirmations-secure-ux-deprecatedDEPRECATED: please use "team-confirmations" insteadDEPRECATED: please use "team-confirmations" insteadtype-bugSomething isn't workingSomething isn't working
Description
Describe the bug
There is a problem with gas calculation when we switch from one type of Send to another (Send ETH/ Send ERC20 / Send NFT). It looks like gas is not re-calculated resulting in non-desired behaviors for both cases.
See below the effects:
- If I switch from an ETH Send back to a Token Send (ERC20 or ERC721) I can see that the proposed gas is the same and if I try to perform the tx I get the error
intrinsic gas too lowand even if I set High gas fees, I still see the error and cannot proceed. The problem is that we are using the gas proposed for the first Send, and it's not re-calculated. We expected higher costs when we interact with contracts and send hex data along our call.
too-low-intrinsic-gas.mp4
- If I switch from a Token Send (ERC20 or ERC721) back to an ETH Send I see that the suggested gas is unnecessary high. It seems that we are carrying over the gas calculation for the Token Send - which is usually higher due to hex data. We should re-calculate the proposed gas for a Send, so user does not spend unnecessary fees.
proposed-gas-too-high.mp4
Affected flows:
- Change Send ETH to Send ERC20
- Change Send ERC20 to Send ETH
- Change Send ETH to Send ERC721
- Change Send ERC721 to Send ETH
To Reproduce
Steps to reproduce the behavior
- Click Send ETH
- Add recipient and amount and proceed to the next screen
- See proposed gas value
- Click Edit
- Change token for an ERC20 Token and proceed
- See proposed gas value is the same
- Try to Send the tx -- get error
intrinsic gas too low
Expected behavior
We should re-calculate the proposed gas everytime we update a transaction
Smartphone (please complete the following information):
- Device: Pixel 6
- OS: Android 12
- App Version: v6.0.1 (1072)
to be added after bug submission by internal support / PM
Severity
- How critical is the impact of this bug on a user?
- Add stats if available on % of customers impacted
- Is this visible to all users?
- Is this tech debt?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Sev2-normalAn issue that may lead to users misunderstanding some limited risks they are takingAn issue that may lead to users misunderstanding some limited risks they are takingarea-gasteam-confirmations-secure-ux-deprecatedDEPRECATED: please use "team-confirmations" insteadDEPRECATED: please use "team-confirmations" insteadtype-bugSomething isn't workingSomething isn't working