-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add feature flag for fiat on-ramp payment #27110
Copy link
Copy link
Closed
Labels
INVALID-ISSUE-TEMPLATEIssue's body doesn't match any issue template.Issue's body doesn't match any issue template.release-7.70.0Issue or pull request that will be included in release 7.70.0Issue or pull request that will be included in release 7.70.0
Metadata
Metadata
Assignees
Labels
INVALID-ISSUE-TEMPLATEIssue's body doesn't match any issue template.Issue's body doesn't match any issue template.release-7.70.0Issue or pull request that will be included in release 7.70.0Issue or pull request that will be included in release 7.70.0
Type
Fields
Give feedbackNo fields configured for issues without a type.
Goal
Gate the entire fiat payment feature behind the
confirmations_pay_fiatLaunchDarkly flag so it can be enabled incrementally via remote config.Scope
confirmations_pay_fiatremote feature flag (already created in LaunchDarkly) viaselectRemoteFeatureFlags.selectPayFiatEnabledselector following the existing pattern (selectMetaMaskPayFlags,selectGasFeeTokenFlags, etc.):featureFlags?.confirmations_pay_fiatfrom remote flags.enabledboolean, defaulting tofalse.useIsPayFiatEnabled) or just use the selector directly — follow whichever pattern the codebase prefers.Acceptance criteria
selectPayFiatEnabledreadsconfirmations_pay_fiatfrom remote feature flags.falsewhen the flag is absent orenabledis nottrue.truewhen LD hasconfirmations_pay_fiat.enabled = true.false, flagtrue.Out of scope
Key files
app/selectors/featureFlagController/confirmations/index.tsapp/selectors/featureFlagController/confirmations/index.test.ts