…PC endpoints usage (#15290) ## **Description** This PR implements GitHub [Issue #2707](https://github.com/MetaMask/MetaMask-planning/issues/2707) by adding the ability to track what type of RPC endpoint users are connecting to in MetaMask Mobile. We now capture whether users connect to Ethereum using: - Infura provider (default) - Other providers (like tenderly.co or alchemy.com) - Private IP addresses - Localhost The implementation includes: - A utility function `extractRpcDomain` that parses RPC URLs and returns just the domain part - A domain categorization system that identifies known vs private endpoints - Extension of transaction metrics to include an `rpc_domain` property for all transaction events including "Transaction Submitted", "Transaction Approved", and "Transaction Finalized" - Integration with the NetworkController to retrieve the correct RPC URL for a given chain - **Fixed a bug where `rpc_domain` was missing from failed transaction events specifically** This data will allow us to better understand the most popular RPC endpoints and what percentage of users customize them, helping us optimize our UX accordingly. ### **Key Improvements** - **Consistent RPC domain tracking**: Fixed an issue where `rpc_domain` was missing from "Transaction Finalized" events, particularly for failed transactions - **Enhanced error resilience**: Added robust error handling to ensure the RPC domain is correctly extracted and included in all cases - **Transaction metrics consistency**: Ensured all transaction events have the same properties for better analytics comparisons - **Refactoring**: Of metrics.ts and useSafeChains.ts ### **Privacy and Security Considerations** - Only stores domains from well-known public RPC providers - Returns "private" for custom/unknown endpoints to protect user privacy - Uses locally cached chain data instead of making network requests - Works with Mobile's network settings and preferences ### **Implementation Notes** - Implementation follows the same approach used in the MetaMask Extension - Adapts the design to Mobile's architecture and controller structure - Includes proper error handling and edge case management - Enhanced `handleTransactionFinalizedEventForMetrics` to explicitly retrieve and include RPC domain information ### **Possible values for `rpc_domain`** - Public RPC provider domains: e.g., `mainnet.infura.io`, `eth-mainnet.alchemyapi.io` - Private/Custom endpoints: `private` - Invalid URLs (if encountered): `invalid` ## **Related issues** [MetaMask-planning - #2707](https://github.com/MetaMask/MetaMask-planning/issues/2707) ## **Manual testing steps** Set up MetaMask Mobile with different RPC endpoints: 1. Default Infura provider 2. Custom provider (e.g., Alchemy) 3. Private IP/localhost Submit transactions on these networks and verify that the transaction metrics events include the correct `rpc_domain` property in the analytics data. Specifically test: - Submitted transactions - Approved transactions - Failed transactions - Completed transactions Verify that the `rpc_domain` is present and correct in all cases. ## **Screenshots/Recordings** **Submitting a Send:** <img width="807" alt="Screenshot 2025-05-27 at 10 44 56 AM" src="https://github.com/user-attachments/assets/e7feb1e4-df43-4c80-b021-ada3867b33c1" /> ```json "properties": { "chain_id": "0x1", "rpc_domain": "mainnet.infura.io", "smart_transaction_proxied": false, "smart_transaction_timed_out": false, "source": "MetaMask Mobile", "status": "confirmed", "transaction_envelope_type": "0x2", "transaction_internal_id": "a7108420-3b08-11f0-b0a1-5d6d0fa435b7", "transaction_type": "simple_send" }, ``` **Submitting a Swap:** <img width="250" alt="Screenshot 2025-05-21 at 6 01 30 AM" src="https://github.com/user-attachments/assets/92e5c0d5-c165-4610-b225-c502ba0aa729" /> **Data Sent to Metrics:** ```json { "name": "Transaction Finalized", "properties": { "chain_id": "0x1", "status": "confirmed", "source": "MetaMask Mobile", "transaction_type": "swap", "transaction_envelope_type": "swap", "rpc_domain": "mainnet.infura.io", "transaction_internal_id": "d0100642-7830-42c9-95bd-e209b04a3a1c" }, "sensitiveProperties": { "value": "0x5af3107a4000", "to_address": "0x881d40237659c251811cec9c364ef91dc08d300c", "from_address": "0x7e52459c31989ef14c7e61d5b3b03d0a8e6a5ba6" }, "saveDataRecording": true } ``` **Failed Transactions Case:** The `rpc_domain` property is now consistently included across all transaction statuses, and it correctly shows _**"mainnet.infura.io"**_ instead of **_"private"_** for the Infura domains, thanks to our updated `extractRpcDomain` function and updates to the `generateDefaultTransactionMetrics` function to remove the conditional logic that previously only added RPC domain information for 'submitted' or 'confirmed' transactions. <img width="250" alt="Screenshot 2025-05-27 at 10 50 21 AM" src="https://github.com/user-attachments/assets/22326e9f-ee19-4b8a-b923-fb5569b58832" /> <img width="250" alt="Screenshot 2025-05-21 at 8 31 57 AM" src="https://github.com/user-attachments/assets/8a695ba1-f7e7-4d2f-a526-17692aae92ad" /> https://github.com/user-attachments/assets/f77f5cbf-057a-4d31-a219-46c42274caec ``` LOG METRICS BEING SENT - properties: { "chain_id": "0x1", "status": "failed", "source": "MetaMask Mobile", "transaction_type": "contractInteraction", "transaction_envelope_type": "contractInteraction", "error": "Error: Returned error: execution reverted", "rpc_domain": "mainnet.infura.io", // This is now included "simulation_response": "transaction_revert", "simulation_latency": 0.092, "simulation_receiving_assets_quantity": 0, "simulation_receiving_assets_type": [], "simulation_receiving_assets_value": [], "simulation_sending_assets_quantity": 0, "simulation_sending_assets_type": [], "simulation_sending_assets_value": [], "transaction_internal_id": "7ff9afcb-2eee-11f0-9207-cdd28454b630" } ``` ### **Before** N/A ### **After** * See Above screenshots and proof of data being sent to MetaMetrics ## **Pre-merge author checklist** - [X ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [X] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [X] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: OGPoyraz <omergoktugpoyraz@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>

Uh oh!

Enable Bitrise CI and CircleCI Release #2707

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions