Skip to content

Migration to remove legacy local storage keys from localStorage#9986

Merged
danjm merged 6 commits intodevelopfrom
remove-stale-local-storage-entries-migration
Dec 3, 2020
Merged

Migration to remove legacy local storage keys from localStorage#9986
danjm merged 6 commits intodevelopfrom
remove-stale-local-storage-entries-migration

Conversation

@danjm
Copy link
Copy Markdown
Contributor

@danjm danjm commented Dec 3, 2020

PR #9919 removed use of localStorage. This PR ensures that previously used localStorage keys and data are deleted.

@danjm danjm requested a review from a team as a code owner December 3, 2020 16:52
@danjm danjm requested a review from brad-decker December 3, 2020 16:52
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 3, 2020

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [41eb63e]
Page Load Metrics (394 ± 51 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint298458209
domContentLoaded28163839310550
load28264039410551
domInteractive28163739210550

@danjm danjm force-pushed the remove-stale-local-storage-entries-migration branch from a372d0c to fbc1a7a Compare December 3, 2020 20:07
@danjm danjm force-pushed the remove-stale-local-storage-entries-migration branch from ea5f57a to e49803c Compare December 3, 2020 21:20
Gudahtt
Gudahtt previously approved these changes Dec 3, 2020
@danjm danjm force-pushed the remove-stale-local-storage-entries-migration branch from e49803c to 86fa678 Compare December 3, 2020 22:05
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [86fa678]
Page Load Metrics (436 ± 66 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaintNaNNaNNaNNaNNaN
domContentLoaded27786243413766
load27886943613866
domInteractive27686143413766

@danjm danjm merged commit 1661953 into develop Dec 3, 2020
@danjm danjm deleted the remove-stale-local-storage-entries-migration branch December 3, 2020 23:55
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants