Skip to content

Remove unused state from Redux gas slice#9975

Merged
Gudahtt merged 1 commit intodevelopfrom
remove-unused-gas-state
Dec 3, 2020
Merged

Remove unused state from Redux gas slice#9975
Gudahtt merged 1 commit intodevelopfrom
remove-unused-gas-state

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Dec 2, 2020

The errors and total state has been removed from the gas slice, along with related functions. It appears to have been unused for a long time, though I'm not exactly sure as of when.

@Gudahtt Gudahtt requested a review from a team as a code owner December 2, 2020 21:56
@Gudahtt Gudahtt requested a review from brad-decker December 2, 2020 21:56
@Gudahtt Gudahtt force-pushed the remove-unused-gas-state branch from 24a58bf to f9a200e Compare December 3, 2020 03:51
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [f9a200e]
Page Load Metrics (361 ± 36 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint308457178
domContentLoaded2665193607436
load2675203617536
domInteractive2665183607436

brad-decker
brad-decker previously approved these changes Dec 3, 2020
@brad-decker brad-decker self-assigned this Dec 3, 2020
The `errors` and `total` state has been removed from the `gas` slice,
along with related functions. It appears to have been unused for a long
time, though I'm not exactly sure as of when.
@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented Dec 3, 2020

I had to rebase this to resolve conflicts

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [7961892]
Page Load Metrics (393 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint2999542110
domContentLoaded2845303918641
load2855313938641
domInteractive2835293918641

@Gudahtt Gudahtt merged commit cce690c into develop Dec 3, 2020
@Gudahtt Gudahtt deleted the remove-unused-gas-state branch December 3, 2020 19:53
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants