Use strict equality in unit tests#9966
Merged
darkwing merged 5 commits intoMetaMask:developfrom Dec 3, 2020
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Gudahtt
reviewed
Dec 2, 2020
Member
There was a problem hiding this comment.
I'm not sure we should change this minified code 🤔
Gudahtt
requested changes
Dec 2, 2020
Member
Gudahtt
left a comment
There was a problem hiding this comment.
Thanks, this is fantastic! I've been considering doing this for a while now too - ever since VSCode started warning about it.
I think we're better off leaving the vendored minifed ethereum-tx file alone, but aside from that this looks good!
76a1ace to
a2ef598
Compare
a2ef598 to
cca45d8
Compare
Gudahtt
reviewed
Dec 3, 2020
ui/app/components/app/gas-customization/gas-price-chart/tests/gas-price-chart.component.test.js
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation:
VS Code is warning that the
.equaland similar methods are deprecated, so I've gone to strict equality.