Skip to content

Fix watchAsset symbol validation#9960

Merged
rekmarks merged 1 commit intodevelopfrom
fix-watch-asset-validation
Nov 30, 2020
Merged

Fix watchAsset symbol validation#9960
rekmarks merged 1 commit intodevelopfrom
fix-watch-asset-validation

Conversation

@rekmarks
Copy link
Copy Markdown
Member

@rekmarks rekmarks commented Nov 30, 2020

wallet_watchAsset will now return an error if symbol isn't a string.

@rekmarks rekmarks requested a review from a team as a code owner November 30, 2020 19:24
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Nov 30, 2020

Builds ready [9471cc4]
Page Load Metrics (471 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30113642713
domContentLoaded31562546910148
load31662747110048
domInteractive31462546910148

NiranjanaBinoy
NiranjanaBinoy approved these changes Nov 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rekmarks rekmarks merged commit cb44cff into develop Nov 30, 2020
@rekmarks rekmarks deleted the fix-watch-asset-validation branch November 30, 2020 20:59
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@NiranjanaBinoy NiranjanaBinoy NiranjanaBinoy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rekmarks @metamaskbot @NiranjanaBinoy