Skip to content

add version to page events#9926

Merged
brad-decker merged 1 commit intodevelopfrom
fix-app-analytics
Nov 21, 2020
Merged

add version to page events#9926
brad-decker merged 1 commit intodevelopfrom
fix-app-analytics

Conversation

@brad-decker
Copy link
Copy Markdown
Contributor

Fixes: missing app key in the context of page events

Explanation: page events have not had an app key since 8.1.2, the setting of this context value was moved to the shared implementation but the page was only implemented in the frontend -- resulting in the loss of this context key.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [0274c5d]
Page Load Metrics (352 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint299340178
domContentLoaded24465435010148
load24665635210148
domInteractive24465435010148

@brad-decker brad-decker marked this pull request as ready for review November 20, 2020 22:35
@brad-decker brad-decker requested a review from a team as a code owner November 20, 2020 22:35
@brad-decker brad-decker requested a review from Gudahtt November 20, 2020 22:35
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brad-decker brad-decker merged commit b3fa1e5 into develop Nov 21, 2020
@brad-decker brad-decker deleted the fix-app-analytics branch November 21, 2020 15:38
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants