Skip to content

resolve-url-loader@3.1.2#9925

Merged
rekmarks merged 1 commit intodevelopfrom
resolve-url-loader@3.1.2
Nov 20, 2020
Merged

resolve-url-loader@3.1.2#9925
rekmarks merged 1 commit intodevelopfrom
resolve-url-loader@3.1.2

Conversation

@rekmarks
Copy link
Copy Markdown
Member

Updates the resolve-url-loader dev dependency to get rid of a high vulnerability per yarn audit. The dependency only used for webpack to build our React storybook, and the behavior appears to be the same.

@rekmarks rekmarks requested a review from a team as a code owner November 20, 2020 20:52
@rekmarks rekmarks requested a review from darkwing November 20, 2020 20:52
@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Nov 20, 2020

From looking at the changelog, I don't think we're affected by these breaking changes. We don't use any options or absolute paths.

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [48b637d]
Page Load Metrics (351 ± 51 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint289739147
domContentLoaded25359034910651
load25559135110651
domInteractive25359034910651

@rekmarks rekmarks merged commit f8f3faf into develop Nov 20, 2020
@rekmarks rekmarks deleted the resolve-url-loader@3.1.2 branch November 20, 2020 21:52
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants