Skip to content

Replace patch with Yarn resolution#9923

Merged
kumavis merged 1 commit intoses-lockdown-backgroundfrom
replace-patch-with-yarn-resolution
Nov 21, 2020
Merged

Replace patch with Yarn resolution#9923
kumavis merged 1 commit intoses-lockdown-backgroundfrom
replace-patch-with-yarn-resolution

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Nov 20, 2020

Instead of patching symbol-observable, this ensures that all versions of symbol-observable are resolved to the given range, even if it contradicts the requested range.

@Gudahtt Gudahtt requested review from a team and kumavis as code owners November 20, 2020 15:22
@Gudahtt Gudahtt requested review from EtDu and danjm and removed request for a team and danjm November 20, 2020 15:22
Instead of patching `symbol-observable`, this ensures that all
versions of `symbol-observable` are resolved to the given range, even
if it contradicts the requested range.
@Gudahtt Gudahtt force-pushed the replace-patch-with-yarn-resolution branch from 5059d58 to ba91c89 Compare November 20, 2020 15:25
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [ba91c89]
Page Load Metrics (455 ± 42 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint3094562211
domContentLoaded3075684538842
load3095704558842
domInteractive3075684538842

@kumavis
Copy link
Copy Markdown
Member

kumavis commented Nov 21, 2020

perfect, thanks

@kumavis kumavis merged commit 87c1c7a into ses-lockdown-background Nov 21, 2020
@kumavis kumavis deleted the replace-patch-with-yarn-resolution branch November 21, 2020 02:40
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants