Skip to content

json-rpc-engine@6.1.0#9922

Merged
rekmarks merged 1 commit intodevelopfrom
json-rpc-engine@6.0.0
Dec 2, 2020
Merged

json-rpc-engine@6.1.0#9922
rekmarks merged 1 commit intodevelopfrom
json-rpc-engine@6.0.0

Conversation

@rekmarks
Copy link
Copy Markdown
Member

@rekmarks rekmarks commented Nov 20, 2020 •
edited
Loading

  • json-rpc-engine@6.1.0
    • A major version bump, but not breaking for our purposes, except the exports.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Nov 20, 2020

Builds ready [7b14386]
Page Load Metrics (360 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint309447178
domContentLoaded2696533588541
load2706553608541
domInteractive2696533588541

@rekmarks rekmarks force-pushed the json-rpc-engine@6.0.0 branch from 7b14386 to e188f56 Compare November 20, 2020 17:42
@rekmarks rekmarks force-pushed the json-rpc-engine@6.0.0 branch from e188f56 to 3ffc466 Compare November 20, 2020 17:42
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Nov 20, 2020

Builds ready [3ffc466]
Page Load Metrics (334 ± 30 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint308441147
domContentLoaded2424753326330
load2444783346330
domInteractive2424753326330

@rekmarks rekmarks changed the title json-rpc-engine@6.0.0 json-rpc-engine@6.1.0 Nov 20, 2020
@rekmarks rekmarks marked this pull request as ready for review November 20, 2020 18:09
@rekmarks rekmarks requested a review from a team as a code owner November 20, 2020 18:09
NiranjanaBinoy
NiranjanaBinoy approved these changes Dec 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rekmarks rekmarks merged commit 1da9ad7 into develop Dec 2, 2020
@rekmarks rekmarks deleted the json-rpc-engine@6.0.0 branch December 2, 2020 19:41
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@NiranjanaBinoy NiranjanaBinoy NiranjanaBinoy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NiranjanaBinoy NiranjanaBinoy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rekmarks @metamaskbot @NiranjanaBinoy