Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
91b2e66 to
1ca98b9
Compare
4929dd7 to
03c832b
Compare
03c832b to
6908a44
Compare
Gudahtt
reviewed
Nov 12, 2020
rekmarks
requested changes
Nov 12, 2020
Member
rekmarks
left a comment
There was a problem hiding this comment.
This is great cleanup work! There are some errors to fix and improvements to make, but all but one should be easy to implement!
ui/app/pages/send/send-content/send-amount-row/amount-max-button/amount-max-button.utils.js
Outdated
Show resolved
Hide resolved
rekmarks
requested changes
Nov 12, 2020
5d282e4 to
a9c695a
Compare
rekmarks
requested changes
Nov 12, 2020
Member
rekmarks
left a comment
There was a problem hiding this comment.
Looking good! Just a few more things
a9c695a to
362ddb4
Compare
rekmarks
requested changes
Nov 12, 2020
Member
rekmarks
left a comment
There was a problem hiding this comment.
One last thing:
For all the Must specify [base] and [base] messages, let's make them Must specify valid [base] and [base].
362ddb4 to
e70503f
Compare
kumavis
approved these changes
Nov 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #
Explanation:
We switched to using
getBigNumberin this commit: 24d7d1a ; unfortunately not all use cases are providing required parameters to guarantee expected values, so we should tidy that up.