Add alt text for images in list items#9847
Merged
darkwing merged 1 commit intoMetaMask:developfrom Nov 20, 2020
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
a1b3e0d to
434921b
Compare
434921b to
a2c89a6
Compare
rekmarks
approved these changes
Nov 17, 2020
Member
rekmarks
left a comment
There was a problem hiding this comment.
I think there are other uses of Identicon where an alt text could be added, (perhaps localized?), but this is a great start!
Contributor
|
@darkwing good to merge? |
Contributor
Author
|
I was going to add alts to all of the uses of Identicon but an empty alt is better than none at this point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation:
Adds
alttext to images using the identicon, like the home screen's asset listing. This will be helpful to describe to users using a voice utility what the image represents; additionally, since the alt text is set to "", screen readers will skip it if no text provided.