build - catch build pipeline errors properly#9840
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
1cc80da to
4ee5776
Compare
c3c4829 to
b2ed282
Compare
Builds ready [b2ed282]
Page Load Metrics (420 ± 58 ms)
|
|
QA: this might break the watch-and-build flow on error, need to check |
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM! I can confirm that this makes the build crash correctly when it fails, rather than keep going without printing anything to the console.
|
Oh, it does break the watch flow though. I can see that being undesirable 🤔 But... I'd rather it crash loudly and break the flow, than fail silently I think? Maybe we can make |
|
if you accidentally save with a syntax error it breaks the reload on change flow, so do want to fix that. just needs a try/catch around the bundle on change. ill get to it eventually |
|
sounds like i made an assumption that it would break and your experimentation showed it to be wrong |
|
When I tested this with But if I introduce a build error after the initial build while Ideally we'd keep the process running in the first place, and print the real error in the second, but at least the syntax error scenario doesn't break the watcher. |
Builds ready [d25d0cd]
Page Load Metrics (394 ± 67 ms)
|
|
@Gudahtt addressed both issues 👍 |
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM! I've tested this, and it now works correctly for errors on initial build and on subsequent builds.
Uses
pumpbecause it knows how to handle errors. need to handle errors for every stream you create, errors don't propagate through streams