Skip to content

Add description for the incoming transactions controller#9759

Merged
Gudahtt merged 1 commit intodevelopfrom
add-incoming-transactions-controller-description
Oct 30, 2020
Merged

Add description for the incoming transactions controller#9759
Gudahtt merged 1 commit intodevelopfrom
add-incoming-transactions-controller-description

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Oct 29, 2020

This comment block describes the responsibilities of this controller. This was motivated by a suggestion made during review of #9755 [1]

This comment block describes the responsibilities of this controller.
This was motivated by a suggestion made during review of #9755 [1]

[1]: #9755 (comment)
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [c729c90]
Page Load Metrics (455 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31125432110
domContentLoaded26567445312861
load26767545512861
domInteractive26567345312861

Copy link
Copy Markdown
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Gudahtt Gudahtt merged commit 4bacb91 into develop Oct 30, 2020
@Gudahtt Gudahtt deleted the add-incoming-transactions-controller-description branch October 30, 2020 14:03
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants