Merged
Conversation
If the swaps state is cleared in between the initial quote fetch and the subsequent poll fetch, a `TypeError` will be thrown due to `fetchParams` being set to `null`. This is of no functional consequence, as `fetchParams` _should_ be `null` in this case, and and no further action should be taken. The optional chaining operator is now used to ensure the call no longer throws.
|
Sentry issue: METAMASK-GJPC |
whymarrh
approved these changes
Oct 29, 2020
Contributor
whymarrh
left a comment
There was a problem hiding this comment.
If it's in Sentry it's a real issue! LGTM!
Collaborator
Builds ready [23aac0f]
Page Load Metrics (437 ± 76 ms)
|
danjm
approved these changes
Oct 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the swaps state is cleared in between the initial quote fetch and the subsequent poll fetch, a
TypeErrorwill be thrown due tofetchParamsbeing set tonull. This is of no functional consequence, asfetchParamsshould benullin this case, and and no further action should be taken.The optional chaining operator is now used to ensure the call no longer throws.