prevent environment key from leaking into all builds#9752
Merged
brad-decker merged 1 commit intodevelopfrom Oct 29, 2020
Merged
prevent environment key from leaking into all builds#9752brad-decker merged 1 commit intodevelopfrom
brad-decker merged 1 commit intodevelopfrom
Conversation
Collaborator
Builds ready [0144f28]
Page Load Metrics (430 ± 65 ms)
|
Member
|
@brad-decker is this ready to bring out of draft? |
Contributor
Author
|
@Gudahtt sorry, ready now -- should I mark this as do not merge until 8.1.3 is published or will we just note not to include it in that build? |
Member
|
v8.1.3 is out! So that's no longer a concern. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: all builds in circleci would include the segment write key, resulting in test data in our segment instance.
Explanation: The logic for setting the real key based on the environment was flawed, and the safest way of dealing with this is having a separate key/env name for production environments, even if it's the same underlying value.
Manual testing steps:
NOTE
@Gudahtt, we should probably make this change immediately after the final release of 8.1.3, or include this in the release. Either way I will not update the environment variables in CircleCI until this PR is included in a release to avoid missing the key assignment.