Make swap arrows accessible, make swaps advanced options accessible#9750
Make swap arrows accessible, make swaps advanced options accessible#9750darkwing merged 2 commits intoMetaMask:developfrom
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
| onFromSelect(selectedToToken) | ||
| }} | ||
| /> | ||
| ><img src="/images/icons/swap2.svg" alt="" width="12" height="16" /> |
There was a problem hiding this comment.
@danjm Can I simply add keys and values to app/_locales/en/messages.json? Then localizers will add them to other files?
Also, what label do we want to give this? I'm having trouble thinking of the proper phrase.
There was a problem hiding this comment.
Can I simply add keys and values to app/_locales/en/messages.json? Then localizers will add them to other files?
Yes!
Also, what label do we want to give this? I'm having trouble thinking of the proper phrase.
Something like "Switch from and to tokens"? Or "Switch source and destination tokens"?
danjm
left a comment
There was a problem hiding this comment.
Looks good to me. I think there is one more incoming change. The label? I'll wait for that to approve.
Explanation:
The
^varrow functionality doesn't work by keyboard, nor does the advanced slippage option toggle. This PR fixes those issues.Manual testing steps: